[webkit-changes] [WebKit/WebKit] e042b0: [css-typed-om] support reification of <transform-l...

Antoine Quint noreply at github.com
Thu Oct 20 11:12:34 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e042b03d0d518d05ca6bb17c3ef323055cd16403
      https://github.com/WebKit/WebKit/commit/e042b03d0d518d05ca6bb17c3ef323055cd16403
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-10-20 (Thu, 20 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-normalization/transformvalue-normalization.tentative-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/css/CSSTransformListValue.cpp
    A Source/WebCore/css/CSSTransformListValue.h
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSParserFastPaths.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
    M Source/WebCore/css/typedom/transform/CSSTransformValue.cpp
    M Source/WebCore/css/typedom/transform/CSSTransformValue.h

  Log Message:
  -----------
  [css-typed-om] support reification of <transform-list>
https://bugs.webkit.org/show_bug.cgi?id=246797

Reviewed by Antti Koivisto.

We need to be able to distinguish a <transform-list> from any other type of list. So we
introduce a new CSSValueList subclass for this purpose: CSSTransformListValue. Now, when
reifying values, we can handle CSSTransformListValue specifically and create the individual
components from function values there rather than in CSSStyleValueFactory::reifyValue().

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-normalization/transformvalue-normalization.tentative-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::computedTransform):
* Source/WebCore/css/CSSTransformListValue.cpp: Added.
(WebCore::CSSTransformListValue::CSSTransformListValue):
* Source/WebCore/css/CSSTransformListValue.h: Added.
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isTransformListValue const):
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::parseSimpleTransformList):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeTransform):
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::reifyValue):
* Source/WebCore/css/typedom/transform/CSSTransformValue.cpp:
(WebCore::createTransformComponent):
(WebCore::CSSTransformValue::create):
* Source/WebCore/css/typedom/transform/CSSTransformValue.h:

Canonical link: https://commits.webkit.org/255795@main




More information about the webkit-changes mailing list