[webkit-changes] [WebKit/WebKit] ee8158: Remove dead code in WKDateTimeInputControl

Aditya Keerthi noreply at github.com
Wed Oct 19 15:33:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee8158570ec36ef3a5268592a708d280a2cc4e32
      https://github.com/WebKit/WebKit/commit/ee8158570ec36ef3a5268592a708d280a2cc4e32
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm

  Log Message:
  -----------
  Remove dead code in WKDateTimeInputControl
https://bugs.webkit.org/show_bug.cgi?id=246731
rdar://101237159

Reviewed by Wenson Hsieh.

WKDateTimeInputControl contains a legacy date picker implementation underneath
`USE(UICONTEXTMENU)`. As of iOS 15, `HAVE(UIDATEPICKER_OVERLAY_PRESENTATION)`
and `USE(UICONTEXTMENU)` are equivalent expressions, and the legacy implementation
is never used.

* Source/WTF/wtf/PlatformHave.h:

Removed unused compile time flags.

* Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker initWithView:datePickerMode:]):
(-[WKDateTimePicker showDateTimePicker]):
(-[WKDateTimePicker done:]):
(-[WKDateTimePicker dealloc]):
(-[WKDateTimePicker controlBeginEditing]):
(-[WKDateTimePicker controlEndEditing]):
(-[WKDateTimePickerViewController initWithDatePicker:]): Deleted.
(-[WKDateTimePickerViewController setDelegate:]): Deleted.
(-[WKDateTimePickerViewController viewDidLoad]): Deleted.
(-[WKDateTimePickerViewController resetButtonPressed:]): Deleted.
(-[WKDateTimePickerViewController doneButtonPressed:]): Deleted.
(-[WKDateTimePickerViewController datePickerInsets]): Deleted.
(-[WKDateTimePickerViewController preferredDatePickerSize]): Deleted.
(-[WKDateTimePickerViewController preferredContentSize]): Deleted.
(-[WKDateTimePicker _preferredEdgeInsetsForDateTimePicker]): Deleted.
(-[WKDateTimePicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]): Deleted.
(-[WKDateTimePicker _contextMenuInteraction:styleForMenuWithConfiguration:]): Deleted.
(-[WKDateTimePicker contextMenuInteraction:configurationForMenuAtLocation:]): Deleted.
(-[WKDateTimePicker contextMenuInteraction:willDisplayMenuForConfiguration:animator:]): Deleted.
(-[WKDateTimePicker contextMenuInteraction:willEndForConfiguration:animator:]): Deleted.
(-[WKDateTimePicker removeContextMenuInteraction]): Deleted.
(-[WKDateTimePicker ensureContextMenuInteraction]): Deleted.
(-[WKDateTimePicker dateTimePickerViewControllerDidPressResetButton:]): Deleted.
(-[WKDateTimePicker dateTimePickerViewControllerDidPressDoneButton:]): Deleted.

Canonical link: https://commits.webkit.org/255762@main




More information about the webkit-changes mailing list