[webkit-changes] [WebKit/WebKit] 9290cd: AudioSourceProviderAVFObjC::m_client should be Weak

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9290cdbf360c8d5a6a04d6eacf026891fbc07e94
      https://github.com/WebKit/WebKit/commit/9290cdbf360c8d5a6a04d6eacf026891fbc07e94
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Source/WebCore/platform/audio/AudioSourceProvider.h
    M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h
    M Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
    M Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderCocoa.h
    M Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderCocoa.mm

  Log Message:
  -----------
  AudioSourceProviderAVFObjC::m_client should be Weak
https://bugs.webkit.org/show_bug.cgi?id=246634
rdar://100804084

Reviewed by Eric Carlson.

Make the API contract explicit by having AudioSourceProvider::setClient() take a WeakPtr.

* Source/WebCore/platform/audio/AudioSourceProvider.h:
(WebCore::AudioSourceProvider::setClient):
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h:
* Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::setClient):
* Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderCocoa.h:
* Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderCocoa.mm:
(WebCore::WebAudioSourceProviderCocoa::setClient):

Canonical link: https://commits.webkit.org/255745@main