[webkit-changes] [WebKit/WebKit] 92dbca: Warnings when building ANGLE

Michael Catanzaro noreply at github.com
Wed Oct 19 09:24:41 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92dbcacf4c3e3a8fc6eea68e7022ca59401749e0
      https://github.com/WebKit/WebKit/commit/92dbcacf4c3e3a8fc6eea68e7022ca59401749e0
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Source/ThirdParty/ANGLE/CMakeLists.txt
    M Source/ThirdParty/ANGLE/adjust-angle-include-paths.py

  Log Message:
  -----------
  Warnings when building ANGLE
https://bugs.webkit.org/show_bug.cgi?id=246289

Reviewed by Kenneth Russell.

Let's suppress compiler warnings when building ANGLE. This is
third-party code that is not maintained here. Warnings should be dealt
with upstream.

Historically, I have suppressed individual warnings when they arise.
Upstream is either not building with -Wall like we do, or not using GCC
at all, or else just not fixing warnings. This isn't scaling very well
and the effort required is not worth it.

Also, remove a print statement from adjust-angle-include-paths.py. Our
build should be quiet except in case of bugs.

* Source/ThirdParty/ANGLE/CMakeLists.txt:
* Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:

Canonical link: https://commits.webkit.org/255738@main




More information about the webkit-changes mailing list