[webkit-changes] [WebKit/WebKit] 146ca5: WebCodecsVideoDecoderConfig description should be ...
youennf
noreply at github.com
Wed Oct 19 03:34:40 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 146ca511cb11f32a0eda771a422443af135f48cc
https://github.com/WebKit/WebKit/commit/146ca511cb11f32a0eda771a422443af135f48cc
Author: Youenn Fablet <youennf at gmail.com>
Date: 2022-10-19 (Wed, 19 Oct 2022)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_annexb-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_avc-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp8-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp9_p0-expected.txt
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp
M Source/WebCore/platform/graphics/cv/VideoFrameCV.mm
Log Message:
-----------
WebCodecsVideoDecoderConfig description should be undefined instead of null if there is no description to provide
https://bugs.webkit.org/show_bug.cgi?id=246685
rdar://problem/101288923
Reviewed by Eric Carlson.
When the description size is 0, we should keep the comnfig description be a std::nullopt instead of a null array buffer.
Also fix the creation of the array buffer by providing a proper sampel size.
Covered by rebased tests.
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_annexb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_avc-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp8-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp9_p0-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any.worker_vp9_p2-expected.txt:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCore::WebCodecsVideoEncoder::configure):
(WebCore::WebCodecsVideoEncoder::createEncodedChunkMetadata):
* Source/WebCore/platform/graphics/cv/VideoFrameCV.mm:
(WebCore::VideoFrame::paintInContext): Drive-by fix.
Canonical link: https://commits.webkit.org/255726@main
More information about the webkit-changes
mailing list