[webkit-changes] [WebKit/WebKit] 843735: Make WebCodecsEncodedVideoChunk serializable

youennf noreply at github.com
Wed Oct 19 00:38:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 843735d1dc8b0339e5764363f3f540dd4ec36874
      https://github.com/WebKit/WebKit/commit/843735d1dc8b0339e5764363f3f540dd4ec36874
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/chunk-serialization.any-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunk.cpp
    M Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunk.h
    A Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunkData.h
    M Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunkType.h
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/SerializedScriptValue.cpp
    M Source/WebCore/bindings/js/SerializedScriptValue.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Make WebCodecsEncodedVideoChunk serializable
https://bugs.webkit.org/show_bug.cgi?id=246610
rdar://problem/101239648

Reviewed by Eric Carlson.

Introduce WebCodecsEncodedVideoChunkStorage as thread safe ref counted and have WebCodecsEncodedVideoChunk own a WebCodecsEncodedVideoChunkStorage.
Use WebCodecsEncodedVideoChunkStorage to support serialization.
Either the data will be encoded as IPC or the WebCodecsEncodedVideoChunkStorage pointer will be retrieved from a the serialized value vector.
Update RTCDataChannelTransferTag description to match what we are doing (send an ID).

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/chunk-serialization.any-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunk.cpp:
(WebCore::WebCodecsEncodedVideoChunk::WebCodecsEncodedVideoChunk):
(WebCore::WebCodecsEncodedVideoChunk::copyTo):
* Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunk.h:
(WebCore::WebCodecsEncodedVideoChunkStorage::create):
(WebCore::WebCodecsEncodedVideoChunkStorage::data const):
(WebCore::WebCodecsEncodedVideoChunkStorage::memoryCost const):
(WebCore::WebCodecsEncodedVideoChunk::create):
(WebCore::WebCodecsEncodedVideoChunk::type const):
(WebCore::WebCodecsEncodedVideoChunk::timestamp const):
(WebCore::WebCodecsEncodedVideoChunk::duration const):
(WebCore::WebCodecsEncodedVideoChunk::byteLength const):
(WebCore::WebCodecsEncodedVideoChunk::data const):
(WebCore::WebCodecsEncodedVideoChunk::storage):
(WebCore::WebCodecsEncodedVideoChunkStorage::WebCodecsEncodedVideoChunkStorage):
(WebCore::WebCodecsEncodedVideoChunk::WebCodecsEncodedVideoChunk):
* Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunkData.h: Added.
* Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunkType.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpWebCodecsEncodedVideoChunk):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readWebCodecsEncodedVideoChunk):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::computeMemoryCost const):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
* Source/WebCore/bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::encode const):
(WebCore::SerializedScriptValue::decode):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/255718@main




More information about the webkit-changes mailing list