[webkit-changes] [WebKit/WebKit] 284e48: [WinCairo] Use RenderThemeAdwaita instead of Rende...

Fujii Hironori noreply at github.com
Tue Oct 18 22:44:02 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 284e48c374b08051f649898eecc3d83c1a9d578e
      https://github.com/WebKit/WebKit/commit/284e48c374b08051f649898eecc3d83c1a9d578e
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M Source/WTF/wtf/PlatformUse.h
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/PlatformPlayStation.cmake
    M Source/WebCore/PlatformWin.cmake
    M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp
    M Source/WebCore/rendering/RenderThemeAdwaita.cpp
    M Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp
    M Source/WebKitLegacy/win/WebKitDLL.cpp
    M Source/cmake/OptionsWin.cmake

  Log Message:
  -----------
  [WinCairo] Use RenderThemeAdwaita instead of RenderThemeWin
https://bugs.webkit.org/show_bug.cgi?id=246604

Reviewed by Darin Adler.

RenderThemeWin doesn't work with UseGPUProcessForDOMRenderingEnabled
because it uses Windows API to paint themes to HDC. Use
RenderThemeAdwaita that is painting themes to GraphicsContext.

Turned USE_NEW_THEME macro on because RenderThemeAdwaita depends on
it.

Turned ENABLE_MODERN_MEDIA_CONTROLS macro on. mediaControls.css is a
stylesheet for the legacy media controls. ENABLE_MODERN_MEDIA_CONTROLS
causes a compilation error for the generated C++ source file to embed
mediaControls.css due to a zero size array. So, process the file only
for AppleWin and PlayStation ports that are using the legacy media
controls.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::layoutTraitsClassName const):
* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp:
(WebCore::ScrollbarThemeAdwaita::handleMousePressEvent):
* Source/WebCore/rendering/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::mediaControlsBase64StringForIconNameAndType):
* Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp:
* Source/WebKitLegacy/win/WebKitDLL.cpp:
(DllMain):
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/255715@main




More information about the webkit-changes mailing list