[webkit-changes] [WebKit/WebKit] 1eb475: Remove WebArchiveDebugMode

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1eb47513afb8f84f48d36c0daae0eff1bc9b9d03
      https://github.com/WebKit/WebKit/commit/1eb47513afb8f84f48d36c0daae0eff1bc9b9d03
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M LayoutTests/platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt
    M LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt
    M Source/WTF/Scripts/Preferences/WebPreferences.yaml
    M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/loader/DocumentLoader.h
    M Source/WebCore/loader/ResourceLoader.cpp
    M Source/WebCore/loader/archive/ArchiveResourceCollection.cpp
    M Source/WebCore/loader/archive/ArchiveResourceCollection.h
    M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
    M Source/WebCore/loader/archive/cf/LegacyWebArchive.h
    M Source/WebCore/page/SecurityOrigin.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Tools/TestWebKitAPI/Tests/mac/LoadWebArchive.mm

  Log Message:
  -----------
  Remove WebArchiveDebugMode
https://bugs.webkit.org/show_bug.cgi?id=245488
<rdar://problem/88406961>

Reviewed by Geoffrey Garen.
Original patch by: Kate Cheney <katherine_cheney at apple.com>

Remove use case of WebArchiveDebugMode and deprecate it now that it
is no longer in use. Add a new temporary flag WebArchiveTestMode
that is more aptly named and will maintain existing behavior for
internal tests temporarily.

In addition, for clarity annotate resource URLs in WebArchive with
"webarchive+" prefix, but avoid breaking web content that transits the
pasteboard. If a requested resource has that scheme prefix, then strip it.

* LayoutTests/platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
* LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
* Source/WTF/Scripts/Preferences/WebPreferences.yaml:
* Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::extractMarkupAndArchive):
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingRemoteArchive const):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::scheduleArchiveLoad):
* Source/WebCore/loader/DocumentLoader.h:
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
* Source/WebCore/loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::addResource):
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
* Source/WebCore/loader/archive/ArchiveResourceCollection.h:
* Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createResource):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::extract):
* Source/WebCore/loader/archive/cf/LegacyWebArchive.h:
* Source/WebCore/page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsOpaqueOrigin):
* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebArchiveTestingModeEnabled):
(WKPreferencesGetWebArchiveTestingModeEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setWebArchiveTestingModeEnabled:]):
(-[WKPreferences _webArchiveTestingModeEnabled]):
(-[WKPreferences _setWebArchiveDebugModeEnabled:]):
(-[WKPreferences _webArchiveDebugModeEnabled]):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(+[WebView _canHandleRequest:forMainFrame:]):
* Tools/TestWebKitAPI/Tests/mac/LoadWebArchive.mm:
(TestWebKitAPI::constructArchive):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/255705@main