[webkit-changes] [WebKit/WebKit] 4040b0: [JSC] OpCallShape should include iterator_open and...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4040b04c58d9a5b5b404c83107bcdd857b739c81
      https://github.com/WebKit/WebKit/commit/4040b04c58d9a5b5b404c83107bcdd857b739c81
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M Source/JavaScriptCore/bytecode/OpcodeInlines.h
    M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

  Log Message:
  -----------
  [JSC] OpCallShape should include iterator_open and iterator_next
https://bugs.webkit.org/show_bug.cgi?id=246678
rdar://101279679

Reviewed by Alexey Shvayka.

We originally inserted this check since getter / setter opcodes (op_get_by_id etc.) does not have ArrayProfile.
But now this also excludes iterator_open and iterator_next. This is wrong since they have ArrayProfile correctly.
So we should list up them as OpCallShape, which allows emitting intrinsic-based DFG nodes. For example,

    for (var [key, value] of map);

needs this patch to emit Map#entries intrinsic.

* Source/JavaScriptCore/bytecode/OpcodeInlines.h:
(JSC::isOpcodeShape):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

Canonical link: https://commits.webkit.org/255688@main