[webkit-changes] [WebKit/WebKit] 4303ed: Parsing for at-rule @font-feature-values

Matthieu Dubet noreply at github.com
Tue Oct 18 09:56:51 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4303ed343b77ef5e1fa84de8de8dbd0000cd79f1
      https://github.com/WebKit/WebKit/commit/4303ed343b77ef5e1fa84de8de8dbd0000cd79f1
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/test_font_feature_values_parsing-expected.txt
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/JSCSSRuleCustom.cpp
    A Source/WebCore/css/CSSFontFeatureValuesRule.cpp
    A Source/WebCore/css/CSSFontFeatureValuesRule.h
    A Source/WebCore/css/CSSFontFeatureValuesRule.idl
    M Source/WebCore/css/StyleRule.cpp
    M Source/WebCore/css/StyleRule.h
    M Source/WebCore/css/StyleRuleType.h
    M Source/WebCore/css/StyleSheetContents.cpp
    M Source/WebCore/css/parser/CSSAtRuleID.cpp
    M Source/WebCore/css/parser/CSSAtRuleID.h
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    M Source/WebCore/css/parser/CSSParserImpl.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/inspector/InspectorStyleSheet.cpp

  Log Message:
  -----------
  Parsing for at-rule @font-feature-values
https://bugs.webkit.org/show_bug.cgi?id=246120
rdar://100830599

Reviewed by Myles C. Maxfield and Patrick Angle.

This implementation defines the @font-feature-values at-rule
and the six children font variation at-rules (@styleset, @stylistic, @character-variant,
@swash, @ornaments, @annotation), but those children at-rules are not exposed in CSSOM.

https://www.w3.org/TR/css-fonts-4/#font-feature-values-syntax

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/test_font_feature_values_parsing-expected.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJSNewlyCreated):
* Source/WebCore/css/CSSFontFeatureValuesRule.cpp: Added.
(WebCore::CSSFontFeatureValuesRule::CSSFontFeatureValuesRule):
(WebCore::CSSFontFeatureValuesRule::cssText const):
(WebCore::CSSFontFeatureValuesRule::reattach):
(WebCore::CSSFontFeatureValuesBlockRule::CSSFontFeatureValuesBlockRule):
(WebCore::CSSFontFeatureValuesBlockRule::cssText const):
(WebCore::CSSFontFeatureValuesBlockRule::reattach):
* Source/WebCore/css/CSSFontFeatureValuesRule.h: Added.
* Source/WebCore/css/CSSFontFeatureValuesRule.idl: Added.
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleBase::visitDerived):
(WebCore::StyleRuleBase::createCSSOMWrapper const):
(WebCore::StyleRuleFontFeatureValues::StyleRuleFontFeatureValues):
(WebCore::StyleRuleFontFeatureValuesBlock::StyleRuleFontFeatureValuesBlock):
(WebCore::StyleRuleFontFeatureValues::create):
* Source/WebCore/css/StyleRule.h:
(WebCore::StyleRuleBase::isFontFeatureValuesRule const):
(WebCore::StyleRuleBase::isFontFeatureValuesBlockRule const):
(isType):
* Source/WebCore/css/StyleRuleType.h:
* Source/WebCore/css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::traverseSubresources const):
* Source/WebCore/css/parser/CSSAtRuleID.cpp:
(WebCore::cssAtRuleID):
* Source/WebCore/css/parser/CSSAtRuleID.h:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::computeNewAllowedRules):
(WebCore::CSSParserImpl::consumeRuleList):
(WebCore::CSSParserImpl::consumeAtRule):
(WebCore::CSSParserImpl::consumeQualifiedRule):
(WebCore::fontFeatureValuesTypeMappings):
(WebCore::CSSParserImpl::consumeFontFeatureValuesRuleBlock):
(WebCore::CSSParserImpl::consumeFontFeatureValuesRule):
* Source/WebCore/css/parser/CSSParserImpl.h:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFamilyNameList):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(flattenSourceData):

Canonical link: https://commits.webkit.org/255677@main




More information about the webkit-changes mailing list