[webkit-changes] [WebKit/WebKit] e53707: worker and other values are valid keyword for the ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e53707dae94cde937c24d964f9adf89392b7e3f6
      https://github.com/WebKit/WebKit/commit/e53707dae94cde937c24d964f9adf89392b7e3f6
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M LayoutTests/http/tests/preload/download_resources-expected.txt
    M LayoutTests/http/tests/preload/download_resources_from_header_iframe-expected.txt
    M LayoutTests/http/tests/preload/onerror_event-expected.txt
    A LayoutTests/http/wpt/preload/as-attribute-expected.txt
    A LayoutTests/http/wpt/preload/as-attribute.html
    M LayoutTests/imported/w3c/web-platform-tests/preload/onload-event-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/preload/preload-csp.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/preload/preload-default-csp.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/preload/single-download-preload-expected.txt
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/bindings/js/JSDOMConvertEnumeration.h
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.h
    M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.h
    M Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
    M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h
    M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.h
    M Source/WebCore/loader/LinkLoader.cpp
    M Source/WebCore/loader/LinkLoader.h

  Log Message:
  -----------
  worker and other values are valid keyword for the 'as' property in link preload
https://bugs.webkit.org/show_bug.cgi?id=245415
rdar://problem/100161255

Reviewed by Alex Christensen.

Update binding generator code to allow exposing a parse enumeration routine from a string.
Make use of it in LinkLoader to parse fetch destination and use fetch destination to set the resource type.
Add support for more destination values, including worker, which is tested in the new test.

* LayoutTests/http/wpt/preload/as-attribute-expected.txt: Added.
* LayoutTests/http/wpt/preload/as-attribute.html: Added.
* LayoutTests/http/tests/preload/download_resources-expected.txt:
* LayoutTests/http/tests/preload/download_resources_from_header_iframe-expected.txt:
* LayoutTests/http/tests/preload/onerror_event-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/preload/onload-event-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/preload/preload-csp.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/preload/preload-default-csp.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/preload/single-download-preload-expected.txt:
* Source/WebCore/bindings/js/JSDOMConvertEnumeration.h:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateEnumerationImplementationContent):
(GenerateEnumerationHeaderContent):
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
(WebCore::parseEnumerationFromString<TestCallbackInterface::Enum>):
(WebCore::parseEnumeration<TestCallbackInterface::Enum>):
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.h:
* Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.cpp:
(WebCore::parseEnumerationFromString<TestDefaultToJSONEnum>):
(WebCore::parseEnumeration<TestDefaultToJSONEnum>):
* Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.h:
* Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::parseEnumerationFromString<TestObj::EnumType>):
(WebCore::parseEnumeration<TestObj::EnumType>):
(WebCore::parseEnumerationFromString<TestObj::EnumTrailingComma>):
(WebCore::parseEnumeration<TestObj::EnumTrailingComma>):
(WebCore::parseEnumerationFromString<TestObj::Optional>):
(WebCore::parseEnumeration<TestObj::Optional>):
(WebCore::parseEnumerationFromString<AlternateEnumName>):
(WebCore::parseEnumeration<AlternateEnumName>):
(WebCore::parseEnumerationFromString<TestObj::EnumA>):
(WebCore::parseEnumeration<TestObj::EnumA>):
(WebCore::parseEnumerationFromString<TestObj::EnumB>):
(WebCore::parseEnumeration<TestObj::EnumB>):
(WebCore::parseEnumerationFromString<TestObj::EnumC>):
(WebCore::parseEnumeration<TestObj::EnumC>):
(WebCore::parseEnumerationFromString<TestObj::Kind>):
(WebCore::parseEnumeration<TestObj::Kind>):
(WebCore::parseEnumerationFromString<TestObj::Size>):
(WebCore::parseEnumeration<TestObj::Size>):
(WebCore::parseEnumerationFromString<TestObj::Confidence>):
(WebCore::parseEnumeration<TestObj::Confidence>):
* Source/WebCore/bindings/scripts/test/JS/JSTestObj.h:
* Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
(WebCore::parseEnumerationFromString<TestStandaloneDictionary::EnumInStandaloneDictionaryFile>):
(WebCore::parseEnumeration<TestStandaloneDictionary::EnumInStandaloneDictionaryFile>):
* Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
* Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
(WebCore::parseEnumerationFromString<TestStandaloneEnumeration>):
(WebCore::parseEnumeration<TestStandaloneEnumeration>):
* Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.h:
* Source/WebCore/loader/LinkLoader.cpp:
(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::LinkLoader::preloadIfNeeded):
* Source/WebCore/loader/LinkLoader.h:

Canonical link: https://commits.webkit.org/255669@main