[webkit-changes] [WebKit/WebKit] b6eab2: AX: WebKit does not break AX modality when focus i...
Tyler Wilcock
noreply at github.com
Mon Oct 17 21:48:30 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b6eab27a3f8dd2391c8d6128e711b70f8e5fa31a
https://github.com/WebKit/WebKit/commit/b6eab27a3f8dd2391c8d6128e711b70f8e5fa31a
Author: Tyler Wilcock <tyler_w at apple.com>
Date: 2022-10-17 (Mon, 17 Oct 2022)
Changed paths:
M LayoutTests/accessibility/aria-modal-multiple-dialogs-expected.txt
M LayoutTests/accessibility/aria-modal-multiple-dialogs.html
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
Log Message:
-----------
AX: WebKit does not break AX modality when focus is explicitly moved outside the modal
https://bugs.webkit.org/show_bug.cgi?id=246580
rdar://problem/101209793
Reviewed by Chris Fleizach.
https://www.w3.org/TR/wai-aria-1.1/#aria-modal
"If focus moves to an element outside the modal element, assistive technologies SHOULD NOT limit navigation to the modal element."
With this patch, we now follow this recommendation.
* LayoutTests/accessibility/aria-modal-multiple-dialogs-expected.txt:
* LayoutTests/accessibility/aria-modal-multiple-dialogs.html:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateCurrentModalNode):
(WebCore::AXObjectCache::updateCurrentModalNodeInternal):
Deleted. Function body moved to a lambda inside updateCurrentModalNode.
(WebCore::AXObjectCache::performDeferredCacheUpdate):
* Source/WebCore/accessibility/AXObjectCache.h:
Canonical link: https://commits.webkit.org/255665@main
More information about the webkit-changes
mailing list