[webkit-changes] [WebKit/WebKit] 62f304: [iPadOS] screen.orientation.lock() promise should ...

Chris Dumez noreply at github.com
Mon Oct 17 15:45:39 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62f3048961681f0361a5d596280c91485e72c44e
      https://github.com/WebKit/WebKit/commit/62f3048961681f0361a5d596280c91485e72c44e
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-10-17 (Mon, 17 Oct 2022)

  Changed paths:
    M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp
    M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.h
    M Source/WebKit/UIProcess/ios/WebScreenOrientationManagerProxyIOS.mm

  Log Message:
  -----------
  [iPadOS] screen.orientation.lock() promise should get rejected when the app supports multiple scenes
https://bugs.webkit.org/show_bug.cgi?id=246556

Reviewed by Wenson Hsieh.

screen.orientation.lock() promise should get rejected when the app supports
multiple scenes (multitasks / split-view) on iPad OS. Such apps are not
currently able to lock their orientation.

* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp:
(WebKit::WebScreenOrientationManagerProxy::lock):
(WebKit::WebScreenOrientationManagerProxy::platformShouldRejectLockRequest const):
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.h:
* Source/WebKit/UIProcess/ios/WebScreenOrientationManagerProxyIOS.mm:
(WebKit::WebScreenOrientationManagerProxy::platformShouldRejectLockRequest const):

Canonical link: https://commits.webkit.org/255657@main




More information about the webkit-changes mailing list