[webkit-changes] [WebKit/WebKit] f306cd: Make basic scrolling work with ui-side compositing...

Simon Fraser noreply at github.com
Mon Oct 17 12:56:57 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f306cd3129105493472bc6d46832ee32a81ca072
      https://github.com/WebKit/WebKit/commit/f306cd3129105493472bc6d46832ee32a81ca072
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-10-17 (Mon, 17 Oct 2022)

  Changed paths:
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm

  Log Message:
  -----------
  Make basic scrolling work with ui-side compositing on macOS
https://bugs.webkit.org/show_bug.cgi?id=246640
<rdar://problem/101254817>

Reviewed by Tim Horton.

We already send wheel events to the scrolling tree, but there was no layer movement
because we never changed layer positions; this is because with web process scrolling
there is coordination with the main thread in the form of scroll synchronization.

So add code to manually update layer positions with UI-side compositing. This will
be refined as we bring up a scrolling thread in the UI process.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTree const):
(WebKit::RemoteScrollingCoordinatorProxy::didReceiveWheelEvent):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h:
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm:
(WebKit::RemoteScrollingCoordinatorProxyMac::didReceiveWheelEvent):

Canonical link: https://commits.webkit.org/255643@main




More information about the webkit-changes mailing list