[webkit-changes] [WebKit/WebKit] 3c9c02: [LBSE] Fix SVGImage container size propagation
Nikolas Zimmermann
noreply at github.com
Mon Oct 17 07:08:44 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3c9c0209a07833427073f05c89566ef30cf1b243
https://github.com/WebKit/WebKit/commit/3c9c0209a07833427073f05c89566ef30cf1b243
Author: Nikolas Zimmermann <nzimmermann at igalia.com>
Date: 2022-10-17 (Mon, 17 Oct 2022)
Changed paths:
M LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations
A LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/as-background-image/svg-as-background-6-expected.png
A LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/as-image/svg-non-integer-scaled-image-expected.png
A LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/zoom/page/zoom-background-images-expected.png
M Source/WebCore/loader/cache/CachedImage.cpp
M Source/WebCore/loader/cache/CachedImage.h
M Source/WebCore/platform/graphics/ImageObserver.h
M Source/WebCore/svg/graphics/SVGImage.cpp
Log Message:
-----------
[LBSE] Fix SVGImage container size propagation
https://bugs.webkit.org/show_bug.cgi?id=246034
Reviewed by Rob Buis.
Propagate container size in SVGImage also for RenderSVGRoot, not only LegacyRenderSVGRoot.
This requires to enable SVGImage to actually use LBSE for its documents, if the host document
has LBSE turned on.
This requires plumbing the 'layerBasedSVGEngineEnabled' flag from Settings (reachable via Document)
down to CachedImage / ImageObserver so that we can set the flag, if necessary, before constructing
the document from the network data. Otherwise SVGImage in LBSE will continue to use the legacy
SVG engine.
Update TestExpectations now that SVGImage uses LBSE as well.
* LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations:
* LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/as-background-image/svg-as-background-6-expected.png: Added.
* LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
* LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/zoom/page/zoom-background-images-expected.png: Added.
* Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::load):
* Source/WebCore/loader/cache/CachedImage.h:
* Source/WebCore/platform/graphics/ImageObserver.h:
(WebCore::ImageObserver::layerBasedSVGEngineEnabled const):
* Source/WebCore/svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize const):
(WebCore::SVGImage::dataChanged):
Canonical link: https://commits.webkit.org/255625@main
More information about the webkit-changes
mailing list