[webkit-changes] [WebKit/WebKit] 137c50: [WK2][Unix] Alias IPC::Attachment to UnixFileDescr...

Žan Doberšek noreply at github.com
Mon Oct 17 05:47:27 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 137c50abcab7e335b7889d12c2839eb1af4ee143
      https://github.com/WebKit/WebKit/commit/137c50abcab7e335b7889d12c2839eb1af4ee143
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2022-10-17 (Mon, 17 Oct 2022)

  Changed paths:
    M Source/WebKit/Platform/IPC/Attachment.h
    R Source/WebKit/Platform/IPC/unix/AttachmentUnix.cpp
    M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
    M Source/WebKit/PlatformPlayStation.cmake
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/Shared/WebProcessCreationParameters.h
    M Source/WebKit/Shared/glib/UserMessage.cpp
    M Source/WebKit/SourcesGTK.txt
    M Source/WebKit/SourcesWPE.txt
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp

  Log Message:
  -----------
  [WK2][Unix] Alias IPC::Attachment to UnixFileDescriptor
https://bugs.webkit.org/show_bug.cgi?id=245830

Reviewed by Kimmo Kinnunen and Carlos Garcia Campos.

Make the IPC::Attachment type alias the UnixFileDescriptor type on platforms
compiling with USE(UNIX_DOMAIN_SOCKETS). The previous implementation had other
attachment types besides the file descriptor type based on UnixFileDescriptor,
but those other types weren't used.

* Source/WebKit/Platform/IPC/Attachment.h:
(): Deleted.
(IPC::Attachment::type const): Deleted.
(IPC::Attachment::isNull const): Deleted.
(IPC::Attachment::fd const): Deleted.
(IPC::Attachment::release): Deleted.
(IPC::Attachment::customWriter const): Deleted.
* Source/WebKit/Platform/IPC/unix/AttachmentUnix.cpp: Removed.
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):
(IPC::Connection::sendOutgoingMessage):
(IPC::Connection::sendOutputMessage):
(IPC::AttachmentInfo::setType): Deleted.
(IPC::AttachmentInfo::type const): Deleted.
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<UnixFileDescriptor>::encode):
(IPC::ArgumentCoder<UnixFileDescriptor>::decode):
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebProcessCreationParameters.h:
* Source/WebKit/Shared/glib/UserMessage.cpp:
(WebKit::UserMessage::encode const):
(WebKit::UserMessage::decode):
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::hostFileDescriptor):
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.h:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::hostFileDescriptor):
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.h:
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::hostFileDescriptor const):
* Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/255620@main




More information about the webkit-changes mailing list