[webkit-changes] [WebKit/WebKit] 2d8149: AX: Remove 32 ASSERT_NOT_REACHED AXIsolatedObject ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d8149bbed87335fb0470e35007923445053c4de
      https://github.com/WebKit/WebKit/commit/2d8149bbed87335fb0470e35007923445053c4de
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-10-16 (Sun, 16 Oct 2022)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityLabel.h
    M Source/WebCore/accessibility/AccessibilityMediaObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/AccessibilityProgressIndicator.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h
    M Source/WebCore/accessibility/AccessibilityScrollView.h
    M Source/WebCore/accessibility/AccessibilityScrollbar.h
    M Source/WebCore/accessibility/AccessibilitySlider.h
    M Source/WebCore/accessibility/AccessibilitySpinButton.h
    M Source/WebCore/accessibility/AccessibilityTableColumn.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: Remove 32 ASSERT_NOT_REACHED AXIsolatedObject functions from the AXCoreObject interface
https://bugs.webkit.org/show_bug.cgi?id=246593
rdar://problem/101223521

Reviewed by Chris Fleizach.

This patch:

  - Removes a couple completely unused functions.

  - Moves many functions out of the AXCoreObject interface, instead
    making them virtual at the AccessibilityObject level.

  - Makes some functions completely non-virtual (since they were only
    virtual because of their AXIsolatedObject implementation). This
    should help performance.

  - Moves the caching of AXPropertyName::IsSelectedOptionActive to an
    `#if PLATFORM(ATSPI)` block since that platform is the the only one
    that uses this property.

* Source/WebCore/accessibility/AccessibilityLabel.h:
(isType):
* Source/WebCore/accessibility/AccessibilityMediaObject.h:
(isType):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::scrollViewAncestor const): Deleted.
(WebCore::AccessibilityObject::firstAnonymousBlockChild const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::init):
(WebCore::AccessibilityObject::isAccessibilityScrollbar const):
(WebCore::AccessibilityObject::isAccessibilityScrollViewInstance const):
(WebCore::AccessibilityObject::isAccessibilityTableColumnInstance const):
(WebCore::AccessibilityObject::isSliderThumb const):
(WebCore::AccessibilityObject::isLabel const):
(WebCore::AccessibilityObject::isNativeSpinButton const):
(WebCore::AccessibilityObject::isSpinButtonPart const):
(WebCore::AccessibilityObject::isMediaObject const):
(WebCore::AccessibilityObject::stepValueForRange const):
(WebCore::AccessibilityObject::parentObjectIfExists const):
(WebCore::AccessibilityObject::observableObject const):
(WebCore::AccessibilityObject::isPresentationalChildOfAriaRole const):
(WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren const):
(WebCore::AccessibilityObject::helpText const):
(WebCore::AccessibilityObject::isARIAStaticText const):
(WebCore::AccessibilityObject::ariaLabeledByAttribute const):
(WebCore::AccessibilityObject::ariaDescribedByAttribute const):
(WebCore::AccessibilityObject::anchorElement const):
(WebCore::AccessibilityObject::shouldFocusActiveDescendant const):
(WebCore::AccessibilityObject::index const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::objectID const):
(WebCore::AXCoreObject::isSpinButton const):
* Source/WebCore/accessibility/AccessibilityProgressIndicator.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/AccessibilityScrollView.h:
(isType):
* Source/WebCore/accessibility/AccessibilityScrollbar.h:
(isType):
* Source/WebCore/accessibility/AccessibilitySlider.h:
(isType):
* Source/WebCore/accessibility/AccessibilitySpinButton.h:
(isType):
* Source/WebCore/accessibility/AccessibilityTableColumn.h:
(isType):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::init): Deleted.
(WebCore::AXIsolatedObject::plainTextRangeForVisiblePositionRange const): Deleted.
(WebCore::AXIsolatedObject::index const): Deleted.
(WebCore::AXIsolatedObject::isAccessibilityScrollbar const): Deleted.
(WebCore::AXIsolatedObject::isAccessibilityScrollViewInstance const): Deleted.
(WebCore::AXIsolatedObject::isAccessibilityTableColumnInstance const): Deleted.
(WebCore::AXIsolatedObject::isAccessibilityProgressIndicatorInstance const): Deleted.
(WebCore::AXIsolatedObject::isSliderThumb const): Deleted.
(WebCore::AXIsolatedObject::isInputSlider const): Deleted.
(WebCore::AXIsolatedObject::isLabel const): Deleted.
(WebCore::AXIsolatedObject::isNativeSpinButton const): Deleted.
(WebCore::AXIsolatedObject::isSpinButtonPart const): Deleted.
(WebCore::AXIsolatedObject::isMediaObject const): Deleted.
(WebCore::AXIsolatedObject::isARIATextControl const): Deleted.
(WebCore::AXIsolatedObject::defaultObjectInclusion const): Deleted.
(WebCore::AXIsolatedObject::accessibilityIsIgnoredByDefault const): Deleted.
(WebCore::AXIsolatedObject::stepValueForRange const): Deleted.
(WebCore::AXIsolatedObject::parentObjectIfExists const): Deleted.
(WebCore::AXIsolatedObject::observableObject const): Deleted.
(WebCore::AXIsolatedObject::isPresentationalChildOfAriaRole const): Deleted.
(WebCore::AXIsolatedObject::ariaRoleHasPresentationalChildren const): Deleted.
(WebCore::AXIsolatedObject::helpText const): Deleted.
(WebCore::AXIsolatedObject::isARIAStaticText const): Deleted.
(WebCore::AXIsolatedObject::ariaLabeledByAttribute const): Deleted.
(WebCore::AXIsolatedObject::ariaDescribedByAttribute const): Deleted.
(WebCore::AXIsolatedObject::anchorElement const): Deleted.
(WebCore::AXIsolatedObject::textIteratorBehaviorForTextRange const): Deleted.
(WebCore::AXIsolatedObject::frame const): Deleted.
(WebCore::AXIsolatedObject::mainFrame const): Deleted.
(WebCore::AXIsolatedObject::topDocument const): Deleted.
(WebCore::AXIsolatedObject::scrollViewAncestor const): Deleted.
(WebCore::AXIsolatedObject::shouldFocusActiveDescendant const): Deleted.
(WebCore::AXIsolatedObject::firstAnonymousBlockChild const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/255610@main