[webkit-changes] [WebKit/WebKit] 07860f: Unprefix font-size: -webkit-xxx-large

Tim Nguyen noreply at github.com
Sun Oct 16 02:50:17 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07860fac0bbf23c58f3e2519f46cc8de480452c8
      https://github.com/WebKit/WebKit/commit/07860fac0bbf23c58f3e2519f46cc8de480452c8
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-10-16 (Sun, 16 Oct 2022)

  Changed paths:
    M LayoutTests/editing/style/push-down-font-styles-mac-expected.txt
    M LayoutTests/editing/style/push-down-font-styles-mac.html
    M LayoutTests/editing/style/push-down-font-styles-win-expected.txt
    M LayoutTests/editing/style/push-down-font-styles-win.html
    A LayoutTests/fast/css/font-size-webkit-xxx-large-expected.html
    A LayoutTests/fast/css/font-size-webkit-xxx-large.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-xxx-large.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-valid-expected.txt
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/editing/EditingStyle.cpp
    M Source/WebCore/html/HTMLFontElement.cpp
    M Source/WebCore/platform/graphics/FontCascadeDescription.h
    M Source/WebCore/style/StyleBuilderCustom.h
    M Source/WebCore/style/StyleFontSizeFunctions.h
    M Source/WebCore/style/StyleResolveForFontRaw.cpp
    M Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js

  Log Message:
  -----------
  Unprefix font-size: -webkit-xxx-large
https://bugs.webkit.org/show_bug.cgi?id=246574
rdar://101207950

Reviewed by Myles C. Maxfield.

xxx-large is now part of the spec and matches what we've implemented: https://drafts.csswg.org/css-fonts-4/#valdef-font-size-absolute-size

Make -webkit-xxx-large an alias of xxx-large at parse-time, so it's easy to remove later on.

* LayoutTests/editing/style/push-down-font-styles-mac-expected.txt:
* LayoutTests/editing/style/push-down-font-styles-mac.html:
* LayoutTests/editing/style/push-down-font-styles-win-expected.txt:
* LayoutTests/editing/style/push-down-font-styles-win.html:
* LayoutTests/fast/css/font-size-webkit-xxx-large-expected.html: Added.
* LayoutTests/fast/css/font-size-webkit-xxx-large.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-xxx-large.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-valid-expected.txt:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFontSize):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFontSizeRaw):
* Source/WebCore/editing/EditingStyle.cpp:
(WebCore::legacyFontSizeFromCSSValue):
* Source/WebCore/html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
* Source/WebCore/platform/graphics/FontCascadeDescription.h:
(WebCore::FontCascadeDescription::keywordSizeAsIdentifier const):
(WebCore::FontCascadeDescription::setKeywordSizeFromIdentifier):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueFontSize):
* Source/WebCore/style/StyleFontSizeFunctions.h:
* Source/WebCore/style/StyleResolveForFontRaw.cpp:
(WebCore::Style::resolveForFontRaw):
* Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:

Canonical link: https://commits.webkit.org/255602@main




More information about the webkit-changes mailing list