[webkit-changes] [WebKit/WebKit] 01ef15: Refactor some networkConnectionIntegrity codepaths...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 01ef15458eb22521f5b457c37a407abe6fa90311
      https://github.com/WebKit/WebKit/commit/01ef15458eb22521f5b457c37a407abe6fa90311
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2022-10-14 (Fri, 14 Oct 2022)

  Changed paths:
    M Source/WebCore/inspector/agents/WebConsoleAgent.cpp
    M Source/WebCore/platform/network/cf/ResourceError.h
    M Source/WebCore/platform/network/mac/ResourceErrorMac.mm

  Log Message:
  -----------
  Refactor some networkConnectionIntegrity codepaths for handling resource errors
https://bugs.webkit.org/show_bug.cgi?id=246530
rdar://100523322

Reviewed by Devin Rousso.

Add a flag on `ResourceError` to indicate that the resource error occurred, due to having undesired
effects on network connection integrity. We consult this bit in `WebConsoleAgent` when logging a
console message corresponding to this loading error, in order to provide an alternate message for
the developer.

* Source/WebCore/inspector/agents/WebConsoleAgent.cpp:
(WebCore::networkConnectionIntegrityErrorMessage):
(WebCore::WebConsoleAgent::didFailLoading):
* Source/WebCore/platform/network/cf/ResourceError.h:
(WebCore::ResourceError::compromisedNetworkConnectionIntegrity const):
* Source/WebCore/platform/network/mac/ResourceErrorMac.mm:
(dueToCompromisingNetworkConnectionIntegrity):
(WebCore::ResourceError::platformLazyInit):

Canonical link: https://commits.webkit.org/255572@main