[webkit-changes] [WebKit/WebKit] 970290: Update some Element::requestFullscreen() preflight...

Tim Nguyen noreply at github.com
Fri Oct 14 13:59:09 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 970290aca193e94b34c64d5c490e66e01422833a
      https://github.com/WebKit/WebKit/commit/970290aca193e94b34c64d5c490e66e01422833a
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-10-14 (Fri, 14 Oct 2022)

  Changed paths:
    M LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-dialog-expected.txt
    M Source/WebCore/dom/FullscreenManager.cpp

  Log Message:
  -----------
  Update some Element::requestFullscreen() preflight checks
https://bugs.webkit.org/show_bug.cgi?id=246293

Reviewed by Jer Noble.

- Align old & new fullscreen API codepaths
- Add <dialog> element check per-spec

https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen

* LayoutTests/fullscreen/full-screen-iframe-with-max-width-height.html:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-dialog-expected.txt:
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):

Canonical link: https://commits.webkit.org/255551@main




More information about the webkit-changes mailing list