[webkit-changes] [WebKit/WebKit] bf3359: Implement lastLineBaseline for tables.

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf33593289e7c50abaf636fdca635f3bac442eb4
      https://github.com/WebKit/WebKit/commit/bf33593289e7c50abaf636fdca635f3bac442eb4
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2022-10-14 (Fri, 14 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-003-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-table-001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-table-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-table-003-expected.txt
    M Source/WebCore/rendering/RenderTable.cpp
    M Source/WebCore/rendering/RenderTable.h
    M Source/WebCore/rendering/RenderTableSection.cpp
    M Source/WebCore/rendering/RenderTableSection.h

  Log Message:
  -----------
  Implement lastLineBaseline for tables.
https://bugs.webkit.org/show_bug.cgi?id=244858
rdar://99621230

Reviewed by Alan Bujtas.

CSS Box Alignment Module Level 3 provides a definition of the last
baseline for tables and table rows. We currently keep track of the
baselines for each row if there are cells within that are baseline
aligned, so we just need to add the logic for finding the last baseline
if there are no cells being baseline aligned. This is the same logic
that was already in firstLineBaseline, but instead we are looking at
only the last row. This logic has been refactored out into
baselineFromCellContentEdges and now takes into consideration which
type of baseline alignment we are doing.

Spec reference: https://www.w3.org/TR/css-align-3/#baseline-export

* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-table-003-expected.txt:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::bottomNonEmptySection const):
(WebCore::RenderTable::lastLineBaseline const):
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBaseline const):
(WebCore::RenderTableSection::lastLineBaseline const):
(WebCore::RenderTableSection::baselineFromCellContentEdges const):
* Source/WebCore/rendering/RenderTableSection.h:

Canonical link: https://commits.webkit.org/255546@main