[webkit-changes] [WebKit/WebKit] f0d121: [JSC] Attach descriptive names to private internal...

Yusuke Suzuki noreply at github.com
Thu Oct 13 18:26:36 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0d12119d740b8a27b662eec7f008b72d37d2947
      https://github.com/WebKit/WebKit/commit/f0d12119d740b8a27b662eec7f008b72d37d2947
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-10-13 (Thu, 13 Oct 2022)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSGlobalObject.cpp

  Log Message:
  -----------
  [JSC] Attach descriptive names to private internal functions
https://bugs.webkit.org/show_bug.cgi?id=246474
rdar://101144740

Reviewed by Alexey Shvayka.

This patch attaches the descriptive names to private internal functions in JSC to make it visible in sampling profiler etc.

Before:
    Hottest bytecodes as <numSamples   'functionName#hash:JITType:bytecodeIndex'>
       200    '#<nil>:None:<nil>'
       146    'slice#<nil>:None:<nil>'
       117    'indexOf#<nil>:None:<nil>'
       111    'anonymous#EWjJWT:Baseline:bc#1'

After:
    Hottest bytecodes as <numSamples   'functionName#hash:JITType:bytecodeIndex'>
       149    'concatMemcpy#<nil>:None:<nil>'
       145    'slice#<nil>:None:<nil>'
       126    'indexOf#<nil>:None:<nil>'
       115    'anonymous#EWjJWT:Baseline:bc#1'

* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):

Canonical link: https://commits.webkit.org/255518@main




More information about the webkit-changes mailing list