[webkit-changes] [WebKit/WebKit] 9cad1e: Cherry-pick 6e034bbd2683. rdar://problem/101048572

Alan Coon noreply at github.com
Thu Oct 13 12:47:30 PDT 2022


  Branch: refs/heads/safari-7615.1.9-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cad1e4f79ecc36ce49fbf876105e09ec3082a74
      https://github.com/WebKit/WebKit/commit/9cad1e4f79ecc36ce49fbf876105e09ec3082a74
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-10-13 (Thu, 13 Oct 2022)

  Changed paths:
    M JSTests/stress/arith-min-max-multiple.js
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  -----------
  Cherry-pick 6e034bbd2683. rdar://problem/101048572

    [JSC] Fix ArithMin/ArithMax handling for double, and Int32 speculation
    https://bugs.webkit.org/show_bug.cgi?id=246422
    rdar://101048572

    Reviewed by Justin Michaud.

    This patch fixes two issues: one is just a bug fix and one is a bit theoretical.

    1. FTL ArithMin/ArithMax double case is skipping the first parameter accidentally. This patch fixes it.
    2. DFG ArithMin/ArithMax Int32 case can OSR exit after clobbering first parameter's register, which can theoretically
       puts different output if type speculation failed in the second or later parameters.

    * JSTests/stress/arith-min-max-multiple.js:
    (test7):
    (test8):
    * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
    * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
    (JSC::FTL::DFG::LowerDFGToB3::compileArithMinOrMax):

    Canonical link: https://commits.webkit.org/255465@main

Canonical link: https://commits.webkit.org/255303.2@safari-7615.1.9-branch


  Commit: 37e34ec73d062a3ada41c622ba8e2781b9abbc07
      https://github.com/WebKit/WebKit/commit/37e34ec73d062a3ada41c622ba8e2781b9abbc07
  Author: Alex Christensen <achristensen at webkit.org>
  Date:   2022-10-13 (Thu, 13 Oct 2022)

  Changed paths:
    M Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientInputs.h
    M Source/WebCore/Modules/webauthn/PublicKeyCredentialRequestOptions.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Cherry-pick d03ef2474704. rdar://problem/101057340

    REGRESSION(255205 at main): Not all members of PublicKeyCredentialRequestOptions should be serialized
    https://bugs.webkit.org/show_bug.cgi?id=246432
    rdar://101057340

    Reviewed by J Pascoe.

    * Source/WebCore/Modules/webauthn/PublicKeyCredentialRequestOptions.h:
    * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

    Canonical link: https://commits.webkit.org/255463@main

Canonical link: https://commits.webkit.org/255303.3@safari-7615.1.9-branch


Compare: https://github.com/WebKit/WebKit/compare/665cb556a683...37e34ec73d06


More information about the webkit-changes mailing list