[webkit-changes] [WebKit/WebKit] b9d359: Increase padding between StreamConnectionBuffer::H...

Cameron McCormack noreply at github.com
Wed Oct 12 21:47:46 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9d35939c4a289e7bfcb9016739ade102d262f1c
      https://github.com/WebKit/WebKit/commit/b9d35939c4a289e7bfcb9016739ade102d262f1c
  Author: Cameron McCormack <heycam at apple.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M LayoutTests/ipc/stream-buffer-read-write.html
    M LayoutTests/ipc/stream-check-autoreleasepool.html
    M LayoutTests/ipc/stream-sync-crash-no-timeout.html
    M LayoutTests/ipc/stream-sync-reply-shared-memory.html
    M Source/WebKit/Platform/IPC/StreamConnectionBuffer.h

  Log Message:
  -----------
  Increase padding between StreamConnectionBuffer::Header fields
https://bugs.webkit.org/show_bug.cgi?id=246390
<rdar://problem/101063947>

Reviewed by Kimmo Kinnunen.

If these fields should be on separate CPU cache lines, the alignment of
the second field needs to be at least 128 bytes on ARM64. It's 64 bytes
on some other architectures (including x86_64), but we use 128
everywhere for simplicity.

* LayoutTests/ipc/stream-buffer-read-write.html:
* LayoutTests/ipc/stream-check-autoreleasepool.html:
* LayoutTests/ipc/stream-sync-crash-no-timeout.html:
* LayoutTests/ipc/stream-sync-reply-shared-memory.html:
* Source/WebKit/Platform/IPC/StreamConnectionBuffer.h:

Canonical link: https://commits.webkit.org/255469@main




More information about the webkit-changes mailing list