[webkit-changes] [WebKit/WebKit] 4d0bfb: [JSC] Use watchpoint-set for StringPrototype sane ...

Yusuke Suzuki noreply at github.com
Wed Oct 12 11:59:20 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d0bfb7d6dd5a7cd3fa6e6649336bd74dffb9da3
      https://github.com/WebKit/WebKit/commit/4d0bfb7d6dd5a7cd3fa6e6649336bd74dffb9da3
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGGraph.h
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
    M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
    M Source/JavaScriptCore/runtime/JSGlobalObject.h
    M Source/JavaScriptCore/runtime/JSGlobalObjectInlines.h
    M Source/JavaScriptCore/runtime/StringPrototype.h

  Log Message:
  -----------
  [JSC] Use watchpoint-set for StringPrototype sane chain checks
https://bugs.webkit.org/show_bug.cgi?id=246384
rdar://101062242

Reviewed by Justin Michaud.

This patch uses JSGlobalObject's WatchpointSet for StringPrototype sane chain checks
in DFG / FTL so that we can purge adhoc transition watchpoint insertion from DFG / FTL.
This basically consolidates watchpoints into JSGlobalObject instead of scattering them
in various Structures at random places, and it paves the way to uDFG: decoupling JSGlobalObject
and checking particular watchpoint set condition is easier for LinkerIR in uDFG.

* Source/JavaScriptCore/dfg/DFGGraph.h:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAtImpl):
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::installSaneChainWatchpoints):
* Source/JavaScriptCore/runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::stringPrototypeChainIsSaneWatchpointSet):
* Source/JavaScriptCore/runtime/JSGlobalObjectInlines.h:
(JSC::JSGlobalObject::stringPrototypeChainIsSane):
* Source/JavaScriptCore/runtime/StringPrototype.h:

Canonical link: https://commits.webkit.org/255449@main




More information about the webkit-changes mailing list