[webkit-changes] [WebKit/WebKit] eeb092: Port WebEvent decoders to the new serialization fo...

Gavin noreply at github.com
Wed Oct 12 10:35:44 PDT 2022 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eeb092500c24e78b07ac07b1737a343767f9d020
      https://github.com/WebKit/WebKit/commit/eeb092500c24e78b07ac07b1737a343767f9d020
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Shared/API/c/WKSharedAPICast.h
    M Source/WebKit/Shared/NativeWebKeyboardEvent.h
    M Source/WebKit/Shared/NativeWebMouseEvent.h
    M Source/WebKit/Shared/NativeWebTouchEvent.h
    M Source/WebKit/Shared/NavigationActionData.cpp
    M Source/WebKit/Shared/NavigationActionData.h
    M Source/WebKit/Shared/WebEvent.cpp
    M Source/WebKit/Shared/WebEvent.h
    A Source/WebKit/Shared/WebEvent.serialization.in
    M Source/WebKit/Shared/WebEventConversion.cpp
    A Source/WebKit/Shared/WebEventModifier.h
    M Source/WebKit/Shared/WebKeyboardEvent.cpp
    M Source/WebKit/Shared/WebKeyboardEvent.h
    M Source/WebKit/Shared/WebMouseEvent.cpp
    M Source/WebKit/Shared/WebMouseEvent.h
    M Source/WebKit/Shared/WebTouchEvent.cpp
    M Source/WebKit/Shared/WebTouchEvent.h
    M Source/WebKit/Shared/WebWheelEvent.cpp
    M Source/WebKit/Shared/WebWheelEvent.h
    M Source/WebKit/Shared/WebWheelEventCoalescer.cpp
    M Source/WebKit/Shared/gtk/NativeWebKeyboardEventGtk.cpp
    M Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp
    M Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp
    M Source/WebKit/Shared/gtk/WebEventFactory.cpp
    M Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm
    M Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm
    M Source/WebKit/Shared/ios/WebIOSEventFactory.h
    M Source/WebKit/Shared/ios/WebIOSEventFactory.mm
    R Source/WebKit/Shared/ios/WebTouchEventIOS.cpp
    M Source/WebKit/Shared/libwpe/WebEventFactory.cpp
    M Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm
    M Source/WebKit/Shared/mac/WebEventFactory.h
    M Source/WebKit/Shared/mac/WebEventFactory.mm
    M Source/WebKit/Shared/mac/WebGestureEvent.cpp
    M Source/WebKit/Shared/mac/WebGestureEvent.h
    M Source/WebKit/Shared/win/WebEventFactory.cpp
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/APINavigationAction.h
    M Source/WebKit/UIProcess/API/APIUIClient.h
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.mm
    M Source/WebKit/UIProcess/API/glib/WebKitPrivate.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitPrivate.h
    M Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
    M Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp
    M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp
    M Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/gtk/PointerLockManager.cpp
    M Source/WebKit/UIProcess/gtk/PointerLockManager.h
    M Source/WebKit/UIProcess/gtk/PointerLockManagerWayland.cpp
    M Source/WebKit/UIProcess/gtk/PointerLockManagerWayland.h
    M Source/WebKit/UIProcess/gtk/PointerLockManagerX11.cpp
    M Source/WebKit/UIProcess/gtk/PointerLockManagerX11.h
    M Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h
    M Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp
    M Source/WebKit/WebProcess/WebPage/PageBanner.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  Port WebEvent decoders to the new serialization format
https://bugs.webkit.org/show_bug.cgi?id=246217
rdar://100901053

Reviewed by Alex Christensen.

Port the various WebEvent encoders/decoders to the new IPC serialization
format. This includes:
    * WebEvent
    * WebEventModifier
    * WebEvent::Type
    * WebKeyboardEvent
    * WebTouchEvent
    * WebMouseEvent
    * WebMouseEvent::Button
    * WebMouseEvent::SyntheticClickType
    * WebGestureEvent
    * WebWheelEvent
    * WebWheelEvent::Granularity
    * WebWheelEvent::Phase
    * WebWheelEvent::MomentumEndType

* Source/WebCore/dom/TouchEvent.h:
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
* Source/WebKit/Shared/NativeWebKeyboardEvent.h:
* Source/WebKit/Shared/NativeWebMouseEvent.h:
* Source/WebKit/Shared/NativeWebTouchEvent.h:
* Source/WebKit/Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::decode):
* Source/WebKit/Shared/NavigationActionData.h:
* Source/WebKit/Shared/WebEvent.cpp:
(WebKit::WebEvent::WebEvent):
(WebKit::WebEvent::encode const): Deleted.
(WebKit::WebEvent::decode): Deleted.
* Source/WebKit/Shared/WebEvent.h:
(WebKit::WebEvent::shiftKey const):
(WebKit::WebEvent::controlKey const):
(WebKit::WebEvent::altKey const):
(WebKit::WebEvent::metaKey const):
(WebKit::WebEvent::capsLockKey const):
(WebKit::WebEvent::modifiers const):
* Source/WebKit/Shared/WebEvent.serialization.in: Added.
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
* Source/WebKit/Shared/WebEventModifier.h: Copied from Source/WebKit/Shared/ios/WebIOSEventFactory.h.
* Source/WebKit/Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::encode const): Deleted.
(WebKit::WebKeyboardEvent::decode): Deleted.
* Source/WebKit/Shared/WebKeyboardEvent.h:
* Source/WebKit/Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::encode const): Deleted.
(WebKit::WebMouseEvent::decode): Deleted.
* Source/WebKit/Shared/WebMouseEvent.h:
* Source/WebKit/Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::WebTouchEvent):
(WebKit::WebTouchEvent::encode const): Deleted.
(WebKit::WebTouchEvent::decode): Deleted.
* Source/WebKit/Shared/WebTouchEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
* Source/WebKit/Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode const): Deleted.
(WebKit::WebWheelEvent::decode): Deleted.
* Source/WebKit/Shared/WebWheelEvent.h:
* Source/WebKit/Shared/WebWheelEventCoalescer.cpp:
(WebKit::WebWheelEventCoalescer::coalesce):
* Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::webEventModifierFlags):
* Source/WebKit/Shared/ios/WebIOSEventFactory.h:
* Source/WebKit/Shared/ios/WebIOSEventFactory.mm:
(WebIOSEventFactory::toUIKeyModifierFlags):
(modifiersForEvent):
(WebIOSEventFactory::createWebMouseEvent):
* Source/WebKit/Shared/ios/WebTouchEventIOS.cpp: Removed.
* Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:
(WebKit::NativeWebGestureEvent::NativeWebGestureEvent):
* Source/WebKit/Shared/mac/WebEventFactory.h:
* Source/WebKit/Shared/mac/WebEventFactory.mm:
(WebKit::modifiersForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::toNSEventModifierFlags):
* Source/WebKit/Shared/mac/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::encode const): Deleted.
(WebKit::WebGestureEvent::decode): Deleted.
* Source/WebKit/Shared/mac/WebGestureEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::gestureRotation const):
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/APINavigationAction.h:
* Source/WebKit/UIProcess/API/APIUIClient.h:
(API::UIClient::mouseDidMoveOverElement):
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::protocolModifierToWebEventModifier):
(WebKit::WebAutomationSession::performMouseInteraction):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.h:
* Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::WebAutomationSession::platformWebModifiersFromRaw):
* Source/WebKit/UIProcess/Cocoa/UIDelegate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::mouseDidMoveOverElement):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::mouseDidMoveOverElement):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:
(webEventModifiersForUIKeyModifierFlags):
(-[WKMouseGestureRecognizer createMouseEventWithType:wasCancelled:]):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::handleTwoFingerTapAtPoint):
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::attemptSyntheticClick):
(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:
(API::InjectedBundle::PageUIClient::mouseDidMoveOverElement):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
(WebKit::InjectedBundleNavigationAction::modifiers const):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showContextMenuAtPoint):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement):
* Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp:
(WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::simulateMouseDown):
(WebKit::WebPage::simulateMouseUp):
(WebKit::WebPage::simulateMouseMotion):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::dispatchSyntheticMouseMove):
(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completeSyntheticClick):
(WebKit::WebPage::attemptSyntheticClick):
(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):
(WebKit::WebPage::handleTwoFingerTapAtPoint):
(WebKit::WebPage::commitPotentialTap):

Canonical link: https://commits.webkit.org/255441@main

More information about the webkit-changes mailing list