[webkit-changes] [WebKit/WebKit] 1b1809: Merge 255405 at main - Fix !ENABLE(ACCESSIBILITY) bui...

Wed Oct 12 06:37:06 PDT 2022

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b1809820972319bda6ad5e6574aa3e175fae0b1
      https://github.com/WebKit/WebKit/commit/1b1809820972319bda6ad5e6574aa3e175fae0b1
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  Merge 255405 at main - Fix !ENABLE(ACCESSIBILITY) build after 255279 at main
https://bugs.webkit.org/show_bug.cgi?id=246362

Unreviewed build fix.

Add an implementation of AXObjectCache::onSelectedChanged for
`!ENABLE(ACCESSIBILITY)`.

* Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/255405@main

(cherry picked from commit 6db040eda0e83252e346eff4a0829e8ec9545eb8)

  Commit: bfde9e4816358f45666f2f1ffad7233fb6decef8
      https://github.com/WebKit/WebKit/commit/bfde9e4816358f45666f2f1ffad7233fb6decef8
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt
    A LayoutTests/platform/mac/accessibility/loading-iframe-updates-axtree-expected.txt
    M LayoutTests/platform/win/TestExpectations
    M LayoutTests/platform/wincairo-wk1/TestExpectations
    M LayoutTests/platform/wk2/TestExpectations
    M Source/WebCore/rendering/RenderWidget.cpp

  Log Message:
  -----------
  Merge 255407 at main - Fix issue where iframe content wasn't included in the accessibility tree

Fix issue where iframe content wasn't included in the accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=117456

Reviewed by Chris Fleizach.

Merge - https://chromium.googlesource.com/chromium/blink/+/af4e73e2bfb32fce56854ef0dab33077c7fa6bff

Have RenderWidget notify the accessibility object when its widget changes, otherwise the
AccessibilityRenderObject for the iframe might have a stale reference to the previous widget. (This
would not crash, it would just result in an empty subtree until some other event triggered it to
update.)

This allows us to re-enable this test, that was previously failing flakily or being skipped because
of this bug: loading-iframe-updates-axtree.html

* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget): Update to add stale condition
* LayoutTests/platform/win/TestExpectations: Remove Skipped Test "loading-iframe-updates-axtree.html"
* LayoutTests/platform/wincairo-wk1/TestExpectations: Remove Skipped Test "loading-iframe-updates-axtree.html"
* LayoutTests/platform/wk2/TestExpectations: Remove Skipped Test "loading-iframe-updates-axtree.html"
* LayoutTests/platform/mac/accessibility/loading-iframe-updates-axtree-expected.txt: Add Platform Specific Test Expectations
* LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt: Update Test Expectations

Canonical link: https://commits.webkit.org/255407@main

(cherry picked from commit 0efc0bf9f32501aa0d73f867043d0ba1cc417d40)

  Commit: c644908ac7c251e5658707dd14afe0ef83d249ae
      https://github.com/WebKit/WebKit/commit/c644908ac7c251e5658707dd14afe0ef83d249ae
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom.html
    A LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.html
    R LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.png
    R LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.txt
    M LayoutTests/transforms/3d/general/cssmatrix-3d-zoom.html
    M Source/WebCore/css/TransformFunctions.cpp
    M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
    M Source/WebCore/platform/graphics/transforms/TransformationMatrix.h

  Log Message:
  -----------
  Merge 255416 at main - CSS 3D transform by matrix3d with translations doesn't take page zoom into account
https://bugs.webkit.org/show_bug.cgi?id=164580

Reviewed by Antoine Quint.

matrix3d() had a problem if matrix3d() includes translations and page
zoom was applied. The translation component should be treated in the
initial page zoom.
scale3d(zoom, zoom, zoom) × matrix × scale3d(1 / zoom, 1 / zoom, 1 / zoom)

Cherry-picked Blink's change.
<https://codereview.chromium.org/2482753002>

* LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom.html:
* LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.html: Added.
* LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.png: Removed.
* LayoutTests/transforms/3d/general/cssmatrix-3d-zoom-expected.txt: Removed.
* LayoutTests/transforms/3d/general/cssmatrix-3d-zoom.html: Converted
to a ref-test.
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::matrixTransformValue):
(WebCore::zoomAdjustedNumberValue): Deleted.
* Source/WebCore/css/TransformFunctions.cpp:
(WebCore::transformsForValue):
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::zoom):
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:

Canonical link: https://commits.webkit.org/255416@main

(cherry picked from commit fee4b197a6bbb3af225fcd22d2e82af809e1564e)

  Commit: 16a14fe90bc29d0b4c06ed00071f3185ed0f3585
      https://github.com/WebKit/WebKit/commit/16a14fe90bc29d0b4c06ed00071f3185ed0f3585
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp

  Log Message:
  -----------
  Merge 255427 at main - [GStreamer] Passing unexpected value type to g_object_set() leads to buffer over-read
https://bugs.webkit.org/show_bug.cgi?id=246334

Reviewed by Philippe Normand.

Arrange to pass values of the correct size through the g_object_set()
varargs when configuring the videorate GStreamer element.

Bug found by Bastian Krause, who also suggested the fix.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter): Use literal TRUE to
set the "drop-only" property of the videorate element, and the UINT64_C
macro from the standard library to provide a 64-bit unsigned literal for
the "average-period".

Canonical link: https://commits.webkit.org/255427@main

(cherry picked from commit 5964f4b624787e91b79e44de219422b39251e62b)

  Commit: ae23b36653931c33218d916ccc3b98181105f288
      https://github.com/WebKit/WebKit/commit/ae23b36653931c33218d916ccc3b98181105f288
  Author: Guillaume Emont <guijemont at igalia.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M Source/JavaScriptCore/runtime/Options.cpp

  Log Message:
  -----------
  Merge 255425 at main - [JSC] better compilation defaults for arm 32-bit
https://bugs.webkit.org/show_bug.cgi?id=244253

Reviewed by Justin Michaud.

The defaults for various compilation parameters are not optimal for arm
32-bit, especially considering that compilation happens in the main
thread on that platform, thus making big compilations more costly.

This change introduces new default for arm, found using
scikit-optimize's gp_minimize()[1] and running watch-cli.js from
JetStream2 with jsc compiled in 32-bit.

On an average of 5 runs, these parameters provide a score improvement of
1.60% on a raspberry pi 3, and 1.56% on a raspberry pi 4 with similar
conditions.

[1] https://scikit-optimize.github.io/stable/modules/generated/skopt.gp_minimize.html

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::overrideDefaults): new defaults of various parameters for CPU(ARM)

Canonical link: https://commits.webkit.org/255425@main

(cherry picked from commit 8683d7558197d47d60fc1df3f823eebd16dd1ab0)

Compare: https://github.com/WebKit/WebKit/compare/0bd0ab020073...ae23b3665393