[webkit-changes] [WebKit/WebKit] 5964f4: [GStreamer] Passing unexpected value type to g_obj...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5964f4b624787e91b79e44de219422b39251e62b
      https://github.com/WebKit/WebKit/commit/5964f4b624787e91b79e44de219422b39251e62b
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp

  Log Message:
  -----------
  [GStreamer] Passing unexpected value type to g_object_set() leads to buffer over-read
https://bugs.webkit.org/show_bug.cgi?id=246334

Reviewed by Philippe Normand.

Arrange to pass values of the correct size through the g_object_set()
varargs when configuring the videorate GStreamer element.

Bug found by Bastian Krause, who also suggested the fix.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter): Use literal TRUE to
set the "drop-only" property of the videorate element, and the UINT64_C
macro from the standard library to provide a 64-bit unsigned literal for
the "average-period".

Canonical link: https://commits.webkit.org/255427@main