[webkit-changes] [WebKit/WebKit] 75277c: [Live Range Selection] Some tests fail due to Appl...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75277ced4576bfd97c2bea91545e6c0dbcc9ece2
      https://github.com/WebKit/WebKit/commit/75277ced4576bfd97c2bea91545e6c0dbcc9ece2
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-10-11 (Tue, 11 Oct 2022)

  Changed paths:
    A LayoutTests/editing/execCommand/remove-format-background-color-live-range-expected.txt
    A LayoutTests/editing/execCommand/remove-format-background-color-live-range.html
    A LayoutTests/editing/execCommand/remove-format-image-live-range-expected.txt
    A LayoutTests/editing/execCommand/remove-format-image-live-range.html
    A LayoutTests/editing/execCommand/remove-format-in-table-cell-live-range-expected.txt
    A LayoutTests/editing/execCommand/remove-format-in-table-cell-live-range.html
    A LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe-live-range-expected.txt
    A LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe-live-range.html
    A LayoutTests/editing/execCommand/remove-formatting-2-live-range-expected.txt
    A LayoutTests/editing/execCommand/remove-formatting-2-live-range.html
    A LayoutTests/editing/execCommand/remove-formatting-live-range-expected.txt
    A LayoutTests/editing/execCommand/remove-formatting-live-range.html
    A LayoutTests/editing/style/apply-font-size-to-multiple-nodes-live-range-expected.txt
    A LayoutTests/editing/style/apply-font-size-to-multiple-nodes-live-range.html
    A LayoutTests/editing/style/apply-style-atomic-live-range-expected.txt
    A LayoutTests/editing/style/apply-style-atomic-live-range.html
    A LayoutTests/editing/style/invalid-font-size-live-range-expected.txt
    A LayoutTests/editing/style/invalid-font-size-live-range.html
    A LayoutTests/editing/style/remove-styled-element-with-style-span-live-range-expected.txt
    A LayoutTests/editing/style/remove-styled-element-with-style-span-live-range.html
    A LayoutTests/editing/undo/redo-split-text-node-live-range-expected.txt
    A LayoutTests/editing/undo/redo-split-text-node-live-range.html
    A LayoutTests/platform/ios/editing/execCommand/remove-formatting-2-live-range-expected.txt
    M Source/WebCore/editing/ApplyStyleCommand.cpp

  Log Message:
  -----------
  [Live Range Selection] Some tests fail due to ApplyStyleCommand not canonicalizing ending selection
https://bugs.webkit.org/show_bug.cgi?id=246314

Reviewed by Darin Adler.

Explicitly canonicalize positions in ApplyStyleCommand::updateStartEnd so that enabling live range selection
do not cause a new test failure. Also add variants of the tests that used to fail without this patch.

* LayoutTests/editing/execCommand/remove-format-background-color-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/remove-format-background-color-live-range.html: Added.
* LayoutTests/editing/execCommand/remove-format-image-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/remove-format-image-live-range.html: Added.
* LayoutTests/editing/execCommand/remove-format-in-table-cell-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/remove-format-in-table-cell-live-range.html: Added.
* LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe-live-range.html: Added.
* LayoutTests/editing/execCommand/remove-formatting-2-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/remove-formatting-2-live-range.html: Added.
* LayoutTests/editing/execCommand/remove-formatting-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/remove-formatting-live-range.html: Added.
* LayoutTests/editing/style/apply-font-size-to-multiple-nodes-live-range-expected.txt: Added.
* LayoutTests/editing/style/apply-font-size-to-multiple-nodes-live-range.html: Added.
* LayoutTests/editing/style/apply-style-atomic-live-range-expected.txt: Added.
* LayoutTests/editing/style/apply-style-atomic-live-range.html: Added.
* LayoutTests/editing/style/invalid-font-size-live-range-expected.txt: Added.
* LayoutTests/editing/style/invalid-font-size-live-range.html: Added.
* LayoutTests/editing/style/remove-styled-element-with-style-span-live-range-expected.txt: Added.
* LayoutTests/editing/style/remove-styled-element-with-style-span-live-range.html: Added.
* LayoutTests/editing/undo/redo-split-text-node-live-range-expected.txt: Added.
* LayoutTests/editing/undo/redo-split-text-node-live-range.html: Added.
* LayoutTests/platform/ios/editing/execCommand/remove-formatting-2-live-range-expected.txt: Added.

* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::updateStartEnd):

Canonical link: https://commits.webkit.org/255409@main