[webkit-changes] [WebKit/WebKit] 0efc0b: Fix issue where iframe content wasn't included in ...
Ahmad Saleem
noreply at github.com
Tue Oct 11 14:47:13 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0efc0bf9f32501aa0d73f867043d0ba1cc417d40
https://github.com/WebKit/WebKit/commit/0efc0bf9f32501aa0d73f867043d0ba1cc417d40
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2022-10-11 (Tue, 11 Oct 2022)
Changed paths:
M LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt
A LayoutTests/platform/mac/accessibility/loading-iframe-updates-axtree-expected.txt
M LayoutTests/platform/win/TestExpectations
M LayoutTests/platform/wincairo-wk1/TestExpectations
M LayoutTests/platform/wk2/TestExpectations
M Source/WebCore/rendering/RenderWidget.cpp
Log Message:
-----------
Fix issue where iframe content wasn't included in the accessibility tree
Fix issue where iframe content wasn't included in the accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=117456
Reviewed by Chris Fleizach.
Merge - https://chromium.googlesource.com/chromium/blink/+/af4e73e2bfb32fce56854ef0dab33077c7fa6bff
Have RenderWidget notify the accessibility object when its widget changes, otherwise the
AccessibilityRenderObject for the iframe might have a stale reference to the previous widget. (This
would not crash, it would just result in an empty subtree until some other event triggered it to
update.)
This allows us to re-enable this test, that was previously failing flakily or being skipped because
of this bug: loading-iframe-updates-axtree.html
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget): Update to add stale condition
* LayoutTests/platform/win/TestExpectations: Remove Skipped Test "loading-iframe-updates-axtree.html"
* LayoutTests/platform/wincairo-wk1/TestExpectations: Remove Skipped Test "loading-iframe-updates-axtree.html"
* LayoutTests/platform/wk2/TestExpectations: Remove Skipped Test "loading-iframe-updates-axtree.html"
* LayoutTests/platform/mac/accessibility/loading-iframe-updates-axtree-expected.txt: Add Platform Specific Test Expectations
* LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt: Update Test Expectations
Canonical link: https://commits.webkit.org/255407@main
More information about the webkit-changes
mailing list