[webkit-changes] [WebKit/WebKit] 21ff04: Have DisplayLink use IPC::Connection::UniqueID, ra...

Simon Fraser noreply at github.com
Tue Oct 11 14:27:10 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21ff04706f4f15f6d82110254309d225306dcd5b
      https://github.com/WebKit/WebKit/commit/21ff04706f4f15f6d82110254309d225306dcd5b
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-10-11 (Tue, 11 Oct 2022)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/mac/DisplayLink.cpp
    M Source/WebKit/UIProcess/mac/DisplayLink.h

  Log Message:
  -----------
  Have DisplayLink use IPC::Connection::UniqueID, rather than IPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=246320
rdar://101014516

Reviewed by Chris Dumez.

DisplayLink doesn't need to know anything about the details of IPC::Connection;
it just needs a unique identifier to use as a hash key, so change it to use
IPC::Connection::UniqueID.

Also make a collection class to hold the set of DisplayLinks, so it's easier
to move them out of WebProcessPool at some point.

* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::nominalFramesPerSecondForDisplay):
(WebKit::WebProcessPool::startDisplayLink):
(WebKit::WebProcessPool::stopDisplayLink):
(WebKit::WebProcessPool::stopDisplayLinks):
(WebKit::WebProcessPool::setDisplayLinkPreferredFramesPerSecond):
(WebKit::WebProcessPool::setDisplayLinkForDisplayWantsFullSpeedUpdates):
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/mac/DisplayLink.cpp:
(WebKit::DisplayLink::addObserver):
(WebKit::DisplayLink::removeObserver):
(WebKit::DisplayLink::removeObservers):
(WebKit::DisplayLink::removeInfoForConnectionIfPossible):
(WebKit::DisplayLink::incrementFullSpeedRequestClientCount):
(WebKit::DisplayLink::decrementFullSpeedRequestClientCount):
(WebKit::DisplayLink::setPreferredFramesPerSecond):
(WebKit::DisplayLinkCollection::displayLinkForDisplay const):
(WebKit::DisplayLinkCollection::add):
* Source/WebKit/UIProcess/mac/DisplayLink.h:
(WebKit::DisplayLinkCollection::displayLinks const):

Canonical link: https://commits.webkit.org/255404@main




More information about the webkit-changes mailing list