[webkit-changes] [WebKit/WebKit] b32f56: [Live Range Selection] editing/text-iterator/find-...

Ryosuke Niwa noreply at github.com
Tue Oct 11 09:38:21 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b32f56beea07525df12af529610ccc3bd839cb1d
      https://github.com/WebKit/WebKit/commit/b32f56beea07525df12af529610ccc3bd839cb1d
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-10-11 (Tue, 11 Oct 2022)

  Changed paths:
    M LayoutTests/editing/text-iterator/find-string-on-flat-tree-expected.txt
    M LayoutTests/editing/text-iterator/find-string-on-flat-tree.html
    M Source/WebCore/dom/StaticRange.idl
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  [Live Range Selection] editing/text-iterator/find-string-on-flat-tree.html fails
https://bugs.webkit.org/show_bug.cgi?id=246312

Reviewed by Darin Adler.

The behavior change is induced by DOMSelection no longer returning a selection on shadow host
when enabling live range selection. Eliminate the behavior differences in the test by introducing
new method "selectedRange" on "internals" object, and using it in the test.

* LayoutTests/editing/text-iterator/find-string-on-flat-tree-expected.txt:
* LayoutTests/editing/text-iterator/find-string-on-flat-tree.html:
* Source/WebCore/dom/StaticRange.idl:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::selectedRange):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/255384@main




More information about the webkit-changes mailing list