[webkit-changes] [WebKit/WebKit] fb5313: AsyncScrolling: add ThreadedScrollingTreeScrolling...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb5313470cebe40287dcdc72ce2664ad2c3f76ed
      https://github.com/WebKit/WebKit/commit/fb5313470cebe40287dcdc72ce2664ad2c3f76ed
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-10-11 (Tue, 11 Oct 2022)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp
    M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
    M Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h
    A Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp
    A Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm
    M Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm
    M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.h

  Log Message:
  -----------
  AsyncScrolling: add ThreadedScrollingTreeScrollingNodeDelegate
https://bugs.webkit.org/show_bug.cgi?id=246212

Reviewed by Simon Fraser.

Make mac and nicosia delegates inherit from
ThreadedScrollingTreeScrollingNodeDelegate and move the common code to
the base class.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::adjustedScrollPosition const):
* Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:
* Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h:
(WebCore::ScrollingTreeScrollingNodeDelegate::updateFromStateNode):
(WebCore::ScrollingTreeScrollingNodeDelegate::adjustedScrollPosition const):
* Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp: Copied from Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp.
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::ThreadedScrollingTreeScrollingNodeDelegate):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::updateFromStateNode):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::startAnimatedScrollToPosition):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::stopAnimatedScroll):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::serviceScrollAnimation):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::createTimer):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::startAnimationCallback):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::stopAnimationCallback):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::allowsHorizontalScrolling const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::allowsVerticalScrolling const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::immediateScrollBy):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::adjustScrollPositionToBoundsIfNecessary):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::scrollOffset const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::pageScaleFactor const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::didStopAnimatedScroll):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::willStartScrollSnapAnimation):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::didStopScrollSnapAnimation):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::scrollExtents const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::deferWheelEventTestCompletionForReason const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::removeWheelEventTestCompletionDeferralForReason const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::adjustedScrollPosition const):
* Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.h: Added.
* Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::willDoProgrammaticScroll):
(WebCore::ScrollingTreeFrameScrollingNodeMac::adjustedScrollPosition const): Deleted.
* Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:
(WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::adjustedScrollPosition const): Deleted.
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::ScrollingTreeScrollingNodeDelegateMac):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::startAnimatedScrollToPosition): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::stopAnimatedScroll): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::createTimer): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::startAnimationCallback): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::stopAnimationCallback): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::serviceScrollAnimation): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalScrolling const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalScrolling const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::immediateScrollBy): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::adjustScrollPositionToBoundsIfNecessary): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::scrollOffset const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::pageScaleFactor const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::didStopAnimatedScroll): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::willStartScrollSnapAnimation): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::didStopScrollSnapAnimation): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::scrollExtents const): Deleted.
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::adjustedScrollPosition const): Deleted.
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::commitStateBeforeChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::adjustedScrollPosition const): Deleted.
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp:
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::ScrollingTreeScrollingNodeDelegateNicosia):
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::immediateScrollBy):
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::updateFromStateNode): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::createTimer): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::startAnimationCallback): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::stopAnimationCallback): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::serviceScrollAnimation): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::allowsHorizontalScrolling const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::allowsVerticalScrolling const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::adjustScrollPositionToBoundsIfNecessary): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::scrollOffset const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::willStartScrollSnapAnimation): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::didStopScrollSnapAnimation): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::didStopAnimatedScroll): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::pageScaleFactor const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::scrollExtents const): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::startAnimatedScrollToPosition): Deleted.
(WebCore::ScrollingTreeScrollingNodeDelegateNicosia::stopAnimatedScroll): Deleted.
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.h:

Canonical link: https://commits.webkit.org/255379@main