[webkit-changes] [WebKit/WebKit] aef26c: [Live Range Selection] A few tests fail due to beh...
Ryosuke Niwa
noreply at github.com
Mon Oct 10 17:39:15 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aef26c62b048ca1c59f33b5013e9d0c5f8eb18ad
https://github.com/WebKit/WebKit/commit/aef26c62b048ca1c59f33b5013e9d0c5f8eb18ad
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2022-10-10 (Mon, 10 Oct 2022)
Changed paths:
A LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt
A LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range.html
A LayoutTests/editing/execCommand/delete-selection-has-style-live-range-expected.txt
A LayoutTests/editing/execCommand/delete-selection-has-style-live-range.html
A LayoutTests/editing/input/select-all-clear-input-method-live-range-expected.txt
A LayoutTests/editing/input/select-all-clear-input-method-live-range.html
A LayoutTests/editing/pasteboard/contenteditable-pre-2-live-range-expected.txt
A LayoutTests/editing/pasteboard/contenteditable-pre-2-live-range.html
A LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-live-range-expected.txt
A LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-live-range.html
A LayoutTests/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-live-range-expected.txt
A LayoutTests/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-live-range.html
A LayoutTests/editing/selection/select-all-user-select-none-live-range-expected.txt
A LayoutTests/editing/selection/select-all-user-select-none-live-range.html
M Source/WebCore/editing/VisibleSelection.cpp
Log Message:
-----------
[Live Range Selection] A few tests fail due to behavior difference in VisibleSelection::selectionFromContentsOfNode
https://bugs.webkit.org/show_bug.cgi?id=246284
Reviewed by Darin Adler.
Explicitly canonicalize selection start & end in VisibleSelection::selectionFromContentsOfNode so that
enabling live range selection wouldn't cause a new test failure.
Also add variants of the tests that enable live range selection.
* LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt: Added.
* LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range.html: Added.
* LayoutTests/editing/execCommand/delete-selection-has-style-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/delete-selection-has-style-live-range.html: Added.
* LayoutTests/editing/input/select-all-clear-input-method-live-range-expected.txt: Added.
* LayoutTests/editing/input/select-all-clear-input-method-live-range.html: Added.
* LayoutTests/editing/pasteboard/contenteditable-pre-2-live-range-expected.txt: Added.
* LayoutTests/editing/pasteboard/contenteditable-pre-2-live-range.html: Added.
* LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-live-range-expected.txt: Added.
* LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-live-range.html: Added.
* LayoutTests/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-live-range-expected.txt: Added.
* LayoutTests/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-live-range.html: Added.
* LayoutTests/editing/selection/select-all-user-select-none-live-range-expected.txt: Added.
* LayoutTests/editing/selection/select-all-user-select-none-live-range.html: Added.
* Source/WebCore/editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::selectionFromContentsOfNode):
Canonical link: https://commits.webkit.org/255372@main
More information about the webkit-changes
mailing list