[webkit-changes] [WebKit/WebKit] 660e00: [results.webkit.org] Support test names with ?

Jonathan Bedard noreply at github.com
Mon Oct 10 07:51:52 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 660e00402272d055860a8bd136e241a2ab54724e
      https://github.com/WebKit/WebKit/commit/660e00402272d055860a8bd136e241a2ab54724e
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2022-10-10 (Mon, 10 Oct 2022)

  Changed paths:
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/suite_controller.py
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/test_controller.py
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/investigate.html
    M Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/util.py
    M Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/util_unittest.py

  Log Message:
  -----------
  [results.webkit.org] Support test names with ?
https://bugs.webkit.org/show_bug.cgi?id=246240
rdar://100917146

Reviewed by Aakash Jain.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/suite_controller.py:
(SuiteController): Unescape suite and test names.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/test_controller.py:
(TestController): Unescape suite and test names.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js: Add function to escape certain
endpoint paths.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint.prototype.reload): Escape suite and test names.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/investigate.html:
* Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/util.py:
(unescape_argument): Decorator which un-escapes the specified URL parameters for the specified characters.
* Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/util_unittest.py:
(UtilTest.test_unescape_decorator):

Canonical link: https://commits.webkit.org/255344@main




More information about the webkit-changes mailing list