[webkit-changes] [WebKit/WebKit] 233ca3: InputEvent.inputType is null when triggering Bold/...

Ryosuke Niwa noreply at github.com
Sun Oct 9 20:46:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 233ca36592805c45e9eeaf69ebd8a8cea6f79fcd
      https://github.com/WebKit/WebKit/commit/233ca36592805c45e9eeaf69ebd8a8cea6f79fcd
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-10-09 (Sun, 09 Oct 2022)

  Changed paths:
    M LayoutTests/editing/execCommand/enabling-and-selection-expected.txt
    M LayoutTests/editing/execCommand/enabling-and-selection.html
    M LayoutTests/fast/forms/plaintext-mode-1-expected.txt
    M LayoutTests/fast/forms/plaintext-mode-1.html
    M Source/WebCore/editing/EditorCommand.cpp

  Log Message:
  -----------
  InputEvent.inputType is null when triggering Bold/Italic/Underline using execCommand
https://bugs.webkit.org/show_bug.cgi?id=201128

Reviewed by Wenson Hsieh.

The bug was caused by applyCommandToFrame not specifying EditAction for execCommand.
Also fixed the bug that FontName, FontSize, and FontSizeDelta were enabled in plain text context.
Without this fix, we'd hit assertions inside CompositeEditCommand::apply.

* LayoutTests/editing/execCommand/enabling-and-selection-expected.txt:
* LayoutTests/editing/execCommand/enabling-and-selection.html:
* LayoutTests/fast/events/input-events-fomat-bold-expected.txt: Added.
* LayoutTests/fast/events/input-events-fomat-bold.html: Added.
* LayoutTests/fast/forms/plaintext-mode-1-expected.txt:
* LayoutTests/fast/forms/plaintext-mode-1.html:

* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::applyCommandToFrame):
(WebCore::createCommandMap):

Canonical link: https://commits.webkit.org/255331@main




More information about the webkit-changes mailing list