[webkit-changes] [WebKit/WebKit] c736ca: [WTF] Unsafe String concatenation in optimized cla...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c736ca45a340bc8340871e961dce909ddbb8ecf7
      https://github.com/WebKit/WebKit/commit/c736ca45a340bc8340871e961dce909ddbb8ecf7
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-10-09 (Sun, 09 Oct 2022)

  Changed paths:
    M Source/WTF/wtf/text/StringView.h

  Log Message:
  -----------
  [WTF] Unsafe String concatenation in optimized clang builds
https://bugs.webkit.org/show_bug.cgi?id=245640

Reviewed by Darin Adler.

Ensure that StringImpl::copyCharacters() is not called with a null string source pointer. The check
done in StringView::getCharactersWithUpconvert() is on allocated memory, so should not have any
negative impact on performance.

* Source/WTF/wtf/text/StringView.h:
(WTF::StringView::getCharactersWithUpconvert const):

Canonical link: https://commits.webkit.org/255330@main