[webkit-changes] [WebKit/WebKit] 15a3cd: Removing table border attribute should remove the ...
Ahmad Saleem
noreply at github.com
Sun Oct 9 01:47:32 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 15a3cd17c15709cb33a59873a7e18543dd3c776e
https://github.com/WebKit/WebKit/commit/15a3cd17c15709cb33a59873a7e18543dd3c776e
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2022-10-09 (Sun, 09 Oct 2022)
Changed paths:
M LayoutTests/fast/table/border-changes-expected.txt
M LayoutTests/fast/table/border-changes.html
A LayoutTests/fast/table/border-remove-border-attribute-expected.html
A LayoutTests/fast/table/border-remove-border-attribute.html
M Source/WebCore/html/HTMLElement.cpp
Log Message:
-----------
Removing table border attribute should remove the visual border
Removing table border attribute should remove the visual border
https://bugs.webkit.org/show_bug.cgi?id=246194
Reviewed by Ryosuke Niwa.
Inspired - https://src.chromium.org/viewvc/blink?view=revision&revision=186883
It is to align Webkit behavior with Gecko / Firefox and Blink / Chrome.
When removing the border attribute the table should look the
same as if the border attribute was never given. So when
we notice the border attribute is removed, make sure
m_borderAttr is set to false so the border will be
removed visually.
* Source/WebCore/html/HTMLElement.cpp:
(HTMLElement::parseBorderWidthAttribute): Added condition for borderWidth is null
* LayoutTests/fast/table/border-remove-border-attribute.html: Added Test Case
* LayoutTests/fast/table/border-remove-border-attribute-expected.html: Added Test Case Expectation
* LayoutTests/fast/table/border-changes.html: Updated Test Case and to use 'js-test.js'
* LayoutTests/fast/table/border-changes-expected.html: Updated Test Case Expectations
Canonical link: https://commits.webkit.org/255322@main
More information about the webkit-changes
mailing list