[webkit-changes] [WebKit/WebKit] 367b4c: keyboard scrolling spring damping animation doesn'...

Fujii Hironori noreply at github.com
Fri Oct 7 19:10:40 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 367b4c1a2c7fdc28e51ca7460ea40e5cb15b8f34
      https://github.com/WebKit/WebKit/commit/367b4c1a2c7fdc28e51ca7460ea40e5cb15b8f34
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M Source/WebCore/platform/KeyboardScrollingAnimator.cpp

  Log Message:
  -----------
  keyboard scrolling spring damping animation doesn't finish and leads to endless flickering scrolling
https://bugs.webkit.org/show_bug.cgi?id=229697

Reviewed by Tim Horton.

The damped oscillation animation of the smooth keyboard scrolling
went into divergent vibration if the frameDuration isn't short
enough. It happened with debug builds with enabling debug
loggings.

Stop the spring if it reaches the ideal position.

* Source/WebCore/platform/KeyboardScrollingAnimator.cpp:
(WebCore::KeyboardScrollingAnimator::updateKeyboardScrollPosition):

Canonical link: https://commits.webkit.org/255306@main




More information about the webkit-changes mailing list