[webkit-changes] [WebKit/WebKit] 13db03: WKWebView is leaking CAMachPorts left and right

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13db036a3d772dd26b87d30332b38d2ef2b3d6fe
      https://github.com/WebKit/WebKit/commit/13db036a3d772dd26b87d30332b38d2ef2b3d6fe
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M Source/WebKit/UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.mm

  Log Message:
  -----------
  WKWebView is leaking CAMachPorts left and right
https://bugs.webkit.org/show_bug.cgi?id=246227
<rdar://100649529>

Reviewed by Wenson Hsieh.

* Source/WebKit/UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.mm:
(-[WKCompositingLayer _setWKContents:withDisplayList:replayForTesting:]):
Sink the +1 CAMachPort into a RetainPtr so it doesn't leak.
Also clarify the comment because someone read it as justifying the bad
leak, as opposed to justifying the `leakSendRight`, which is intentional.

Canonical link: https://commits.webkit.org/255294@main