[webkit-changes] [WebKit/WebKit] 6ccba2: Web Inspector: hard to disable inline breakpoints ...

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ccba2787ef21faafedfda05a69e84064f1a07e8
      https://github.com/WebKit/WebKit/commit/6ccba2787ef21faafedfda05a69e84064f1a07e8
  Author: Devin Rousso <drousso at apple.com>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.css
    M Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.js

  Log Message:
  -----------
  Web Inspector: hard to disable inline breakpoints without entirely removing them
https://bugs.webkit.org/show_bug.cgi?id=246234

Reviewed by Patrick Angle.

This better matches the user expectation that clicking will toggle the disabled state, not remove
the (inline) breakpoint. Removing the (inline) breakpoint can be done via context menu, dragging the
breakpoint icon out of the gutter are for that line, or pressing delete when that breakpoint is
selected in the Breakpoints section of the navigation sidebar in the Sources Tab.

In order to differentiate a placeholder inline breakpoint vs an existing breakpoint, the former is
rendered as the outline of a breakpoint icon, whereas the latter is a solid color (unless it's set
to auto-continue, in which case it will have a small carve-out in the arrow).

* Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.js:
(WI.BreakpointInlineWidget):
(WI.BreakpointInlineWidget.prototype._update):
(WI.BreakpointInlineWidget.prototype._handleClick):
(WI.BreakpointInlineWidget.prototype._handleBreakpointsEnabledDidChange): Added.
* Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.css:
(.inline-widget.breakpoint):
(.inline-widget.breakpoint.placeholder::before): Added.
(.inline-widget.breakpoint:not(.resolved)): Added.
(.inline-widget.breakpoint:not(.placeholder, .disabled)): Renamed from `.inline-widget.breakpoint:not(.disabled)`.
(.inline-widget.breakpoint.auto-continue::after):
Drive-by: Also handle when breakpoints are globally disabled.

Canonical link: https://commits.webkit.org/255292@main