[webkit-changes] [WebKit/WebKit] b85011: CSSTransformComponent.toMatrix should flatten to 2...

Dean Jackson noreply at github.com
Fri Oct 7 14:10:09 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b85011927483d8cab677b6312f4889ebb7ed0f2f
      https://github.com/WebKit/WebKit/commit/b85011927483d8cab677b6312f4889ebb7ed0f2f
  Author: Dean Jackson <dino at apple.com>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening.html
    M Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp
    M Source/WebCore/css/typedom/transform/CSSRotate.cpp
    M Source/WebCore/css/typedom/transform/CSSScale.cpp
    M Source/WebCore/css/typedom/transform/CSSTranslate.cpp

  Log Message:
  -----------
  CSSTransformComponent.toMatrix should flatten to 2d if necessary
https://bugs.webkit.org/show_bug.cgi?id=246172
rdar://100868158

Reviewed by Antoine Quint.

CSSTransformComponent classes should provide a 2d matrix in toMatrix() if their
is2d value is true, regardless of what actual value they have.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening.html: Added.
* Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp: Return a 2d variant of the 3d transform.
(WebCore::CSSMatrixComponent::toMatrix):
* Source/WebCore/css/typedom/transform/CSSRotate.cpp: Ditto.
(WebCore::CSSRotate::toMatrix):
* Source/WebCore/css/typedom/transform/CSSScale.cpp: Ditto.
(WebCore::CSSScale::toMatrix):
* Source/WebCore/css/typedom/transform/CSSTranslate.cpp: Ditto.
(WebCore::CSSTranslate::toMatrix):

Canonical link: https://commits.webkit.org/255290@main




More information about the webkit-changes mailing list