[webkit-changes] [WebKit/WebKit] 1aa25b: AX: The isolated tree doesn't update in response t...

Tyler Wilcock noreply at github.com
Fri Oct 7 10:44:49 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1aa25b42a5ebc726d127fd9efd17b6a90038147d
      https://github.com/WebKit/WebKit/commit/1aa25b42a5ebc726d127fd9efd17b6a90038147d
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/select-element-at-index-expected.txt
    M LayoutTests/accessibility/select-element-at-index.html
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
    M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    M Source/WebCore/html/HTMLOptionElement.cpp

  Log Message:
  -----------
  AX: The isolated tree doesn't update in response to HTMLOptionElement::setSelectedState changes
https://bugs.webkit.org/show_bug.cgi?id=246135
rdar://problem/100839849

Reviewed by Andres Gonzalez.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
Mark accessibility/select-element-at-index.html as fixed.
* LayoutTests/accessibility/select-element-at-index-expected.txt:
* LayoutTests/accessibility/select-element-at-index.html:
Make test async so it can pass in ITM.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::selectedStateChanged):
Also post AXSelectedStateChanged for option elements.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::notificationPlatformName):
(WebCore::AXObjectCache::postPlatformNotification):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelectedState):
Remove #if PLATFORM(ATSPI) guarding the cache update.

Canonical link: https://commits.webkit.org/255279@main




More information about the webkit-changes mailing list