[webkit-changes] [WebKit/WebKit] e5af46: WebGLRenderingContextBase::readPixels should allow...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5af469c39dac303b8e2c1daa1dbc37b055cb609
      https://github.com/WebKit/WebKit/commit/e5af469c39dac303b8e2c1daa1dbc37b055cb609
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
    M Source/WebCore/html/canvas/WebGL2RenderingContext.h
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.idl

  Log Message:
  -----------
  WebGLRenderingContextBase::readPixels should allow null pixels on the IDL level
https://bugs.webkit.org/show_bug.cgi?id=244289
rdar://problem/99078383

Reviewed by Chris Dumez.

Allow null pixels for WebGLRenderingContext.readPixels() and then
generate INVALID_VALUE if pixels == null.

Tested by:
webgl/1.0.x/conformance/reading/read-pixels-test.html
webgl/2.0.y/conformance/reading/read-pixels-test.html

* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::readPixels):
* Source/WebCore/html/canvas/WebGL2RenderingContext.h:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::readPixels):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.idl:

Canonical link: https://commits.webkit.org/255256@main