[webkit-changes] [WebKit/WebKit] 414559: Inexplicable top css being added to audio controls...

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4145593d349c75d33b07016d34d808e1067675a1
      https://github.com/WebKit/WebKit/commit/4145593d349c75d33b07016d34d808e1067675a1
  Author: Devin Rousso <drousso at apple.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio-expected.txt
    M LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio.html
    M LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-expected.txt
    M LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor.html
    M Source/WebCore/Modules/modern-media-controls/controls/media-controls.js
    M Source/WebCore/Modules/modern-media-controls/controls/watchos-media-controls.js
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  -----------
  Inexplicable top css being added to audio controls when height of audio element is adjusted on iOS
https://bugs.webkit.org/show_bug.cgi?id=244723
<rdar://problem/99548840>

Reviewed by Eric Carlson.

In the time since this code was originally added in 185841 at main (and updated in 189848 at main), the
design of the (modern) media controls has changed enough such that centering the controls is no
longer necessary. Instead, the scaling of the `height` will ensure that the controls always fill the
available space, both vertically and horizontally since the `zoom` is applied to both axis equally.

* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsSize):
* Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:
(MediaControls):
(MediaControls.prototype.commitProperty):
(MediaControls.prototype.get shouldCenterControlsVertically): Deleted.
(MediaControls.prototype.set shouldCenterControlsVertically): Deleted.
* Source/WebCore/Modules/modern-media-controls/controls/watchos-media-controls.js:
(WatchOSMediaControls):
(WatchOSMediaControls.prototype.commitProperty):
(WatchOSMediaControls.prototype.get shouldCenterControlsVertically): Deleted.
(WatchOSMediaControls.prototype.set shouldCenterControlsVertically): Deleted.

* LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor.html:
* LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-expected.txt:
* LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio.html:
* LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio-expected.txt:

Canonical link: https://commits.webkit.org/255234@main