[webkit-changes] [WebKit/WebKit] 7f4aa2: Merge 255126 at main - [JSC] Fix assertion failures o...

Yusuke Suzuki noreply at github.com
Thu Oct 6 05:22:41 PDT 2022


  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f4aa2bbf4478815c42896c4c46b16f498978b1a
      https://github.com/WebKit/WebKit/commit/7f4aa2bbf4478815c42896c4c46b16f498978b1a
  Author: Juliana Sims <jsims at igalia.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M Source/WTF/wtf/PlatformCPU.h

  Log Message:
  -----------
  Merge 255126 at main - [JSC] Fix assertion failures on riscv64
https://bugs.webkit.org/show_bug.cgi?id=246025

Reviewed by Žan Doberšek.

* Source/WTF/wtf/PlatformCPU.h: Enable WTF_CPU_NEEDS_ALIGNED_ACCESS for riscv64

Canonical link: https://commits.webkit.org/255126@main

(cherry picked from commit d06087111ae583a546615161adbdf5a9c425f3a2)


  Commit: 1e81e07ac6604e231045f674b25ba30e2c628077
      https://github.com/WebKit/WebKit/commit/1e81e07ac6604e231045f674b25ba30e2c628077
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/resize-observer/ordering-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/resize-observer/ordering.html
    M Source/WebCore/page/Page.cpp

  Log Message:
  -----------
  Merge 255132 at main - Make ResizeObserver and IntersectionObserver timing match other browsers
https://bugs.webkit.org/show_bug.cgi?id=245946

Reviewed by Simon Fraser.

Run IntersectionObservers after ResizeObservers to match Blink and Gecko.

Imported the test from https://github.com/web-platform-tests/wpt/pull/36216

* LayoutTests/imported/w3c/web-platform-tests/resize-observer/ordering-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/resize-observer/ordering.html: Added.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::updateRendering):

Canonical link: https://commits.webkit.org/255132@main

(cherry picked from commit 565a28303653d49dcb47855db613dcdbcf9519be)


  Commit: 3a1797cadb5696abb4f78508d4a2f0187cd25e79
      https://github.com/WebKit/WebKit/commit/3a1797cadb5696abb4f78508d4a2f0187cd25e79
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M LayoutTests/http/wpt/webrtc/audio-video-transform.js
    M LayoutTests/http/wpt/webrtc/audiovideo-script-transform-expected.txt
    M LayoutTests/http/wpt/webrtc/audiovideo-script-transform.html
    M Source/WebCore/Modules/mediastream/RTCEncodedFrame.cpp
    M Source/WebCore/Modules/mediastream/RTCEncodedFrame.h
    M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp
    M Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp

  Log Message:
  -----------
  Merge 255133 at main - https://github.com/webrtc/samples/tree/gh-pages/src/content/insertable-streams/endtoend-encryption is super slow in STP
https://bugs.webkit.org/show_bug.cgi?id=229190
rdar://problem/82290756

Reviewed by Eric Carlson.

We were creating a new array each time RTCEncodedFrame data getter was called.
Instead, we now return the same array each time.

* LayoutTests/http/wpt/webrtc/audio-video-transform.js:
(AudioVideoRTCRtpTransformer):
(AudioVideoRTCRtpTransformer.prototype.process):
* LayoutTests/http/wpt/webrtc/audiovideo-script-transform-expected.txt:
* LayoutTests/http/wpt/webrtc/audiovideo-script-transform.html:
* Source/WebCore/Modules/mediastream/RTCEncodedFrame.cpp:
(WebCore::RTCEncodedFrame::data const):
(WebCore::RTCEncodedFrame::setData):
(WebCore::RTCEncodedFrame::rtcFrame):
* Source/WebCore/Modules/mediastream/RTCEncodedFrame.h:
(WebCore::RTCEncodedFrame::rtcFrame): Deleted.
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:
(WebCore::transformFrame):

Canonical link: https://commits.webkit.org/255133@main

(cherry picked from commit db1f321d704cad6cbbfe878267cde47fc284a835)


  Commit: 07db2208385639960cfd6188db73d074db8cc683
      https://github.com/WebKit/WebKit/commit/07db2208385639960cfd6188db73d074db8cc683
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M Source/JavaScriptCore/API/tests/CustomGlobalObjectClassTest.c
    M Source/JavaScriptCore/API/tests/testapi.c
    M Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp
    M Source/WTF/wtf/Assertions.h
    M Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  Merge 255146 at main - Fix the build on new compilers
https://bugs.webkit.org/show_bug.cgi?id=246033
<rdar://100751561>

Reviewed by Sam Weinig.

* Source/JavaScriptCore/API/tests/CustomGlobalObjectClassTest.c:
(customGlobalObjectClassTest):
(globalObjectSetPrototypeTest):
(globalObjectPrivatePropertyTest):
* Source/JavaScriptCore/API/tests/testapi.c:
(timeZoneIsPST):
(checkForCycleInPrototypeChain):
(valueToObjectExceptionTest):
(globalContextNameTest):
(checkConstnessInJSObjectNames):
* Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:
(JSC::ARM64Disassembler::A64DOpcodeDataProcessing3Source::format):
* Source/WTF/wtf/Assertions.h:
(UNREACHABLE_FOR_PLATFORM):
* Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm:
(-[WKContentRuleListStore _getContentRuleListSourceForIdentifier:completionHandler:]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _contextMenuInteraction:styleForMenuWithConfiguration:]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):

Canonical link: https://commits.webkit.org/255146@main

(cherry picked from commit cbc50087b905f09207431364294d25b68241b169)


  Commit: 5bf70a8d487a233e4dacc285cf0a94de7aa689df
      https://github.com/WebKit/WebKit/commit/5bf70a8d487a233e4dacc285cf0a94de7aa689df
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp

  Log Message:
  -----------
  Merge 255211 at main - [GStreamer][WebRTC] Set MTU to 1200 on RTP payloaders
https://bugs.webkit.org/show_bug.cgi?id=246012

Reviewed by Xabier Rodriguez-Calvar.

Align RTP MTU with libwebrtc implementation, also helping to reduce packet fragmentation.

* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType):
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType):

Canonical link: https://commits.webkit.org/255211@main

(cherry picked from commit 5297100c5cb8bf57b174f32728d0916470339ce9)


  Commit: f0945863f2edba0ffd0a6a2841d8aa3de2b57984
      https://github.com/WebKit/WebKit/commit/f0945863f2edba0ffd0a6a2841d8aa3de2b57984
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-10-06 (Thu, 06 Oct 2022)

  Changed paths:
    A JSTests/stress/array-literal-lexing-for-class-public-fields.js
    M Source/JavaScriptCore/parser/Parser.cpp

  Log Message:
  -----------
  Merge 255212 at main - [JSC] Array literal parsing should lex StringLiteral in the end of parsing
https://bugs.webkit.org/show_bug.cgi?id=245066
rdar://99815328

Reviewed by Mark Lam.

public class field can introduce a case that string literal after the array literal can have
a semantically meaningful content. Previously, we only checked it is string, and we didn't need
to have a string content itself for this case,

    [ ] "Hello"

But now, if it is used with class public field, then we need to know the content of the string to
emit a syntax error based on that.

    class A {
        g = []
        "constructor"() { }
    }

This patch drops array literal parsing's DontBuildStrings flag to lex the string content.

* JSTests/stress/array-literal-lexing-for-class-public-fields.js: Added.
(shouldBe):
(main.a.prototype.g.string_appeared_here):
(main.a):
(main):
* Source/JavaScriptCore/parser/Parser.cpp:
(JSC::Parser<LexerType>::parseArrayLiteral):

Canonical link: https://commits.webkit.org/255212@main

(cherry picked from commit 89c0d4c38e9a62fe1dfdf430fc3624b6bf1db0f8)


Compare: https://github.com/WebKit/WebKit/compare/762ab19c8d32...f0945863f2ed


More information about the webkit-changes mailing list