[webkit-changes] [WebKit/WebKit] 68d473: [Xcode] Link against bmalloc at an exact path

Elliott Williams noreply at github.com
Wed Oct 5 11:38:33 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68d473587bad7080855c7dc7dc1c9d192a863484
      https://github.com/WebKit/WebKit/commit/68d473587bad7080855c7dc7dc1c9d192a863484
  Author: Elliott Williams <emw at apple.com>
  Date:   2022-10-05 (Wed, 05 Oct 2022)

  Changed paths:
    M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    M Source/WTF/WTF.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [Xcode] Link against bmalloc at an exact path
https://bugs.webkit.org/show_bug.cgi?id=246037
rdar://100489172

Reviewed by Alexey Proskuryakov.

Move linkage of libbmalloc.a to JavaScriptCore and TestWTF. Previously,
it was combined with libWTF.a.

Use ld's -force_load option to specify a path to libbmalloc.a, rather
than using search paths. The advantage of this is that we can be sure we
are linking against _our_ bmalloc, avoiding situations where we
accidentally link against an older bmalloc provided by the SDK.

WTF still needs to build after bmalloc's headers, so replace its link
dependency on libbmalloc.a with a product dependency.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig: Link
  JavaScriptCore against bmalloc via -force_load.
* Source/WTF/WTF.xcodeproj/project.pbxproj: Replace link dependency with
  a product dependency. Fix the base path of WTF's Product Dependencies
  phase; it needs to be set to "Products Directory".
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Link
  against bmalloc in targets which link to WTF directly.
* Tools/lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Ditto.

Canonical link: https://commits.webkit.org/255182@main




More information about the webkit-changes mailing list