[webkit-changes] [WebKit/WebKit] c5bd32: Assorted style cleanups

Sam Weinig noreply at github.com
Wed Oct 5 10:07:49 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5bd323a7d366696ac2e218461813541c1a5efa4
      https://github.com/WebKit/WebKit/commit/c5bd323a7d366696ac2e218461813541c1a5efa4
  Author: Sam Weinig <weinig at apple.com>
  Date:   2022-10-05 (Wed, 05 Oct 2022)

  Changed paths:
    M Source/WebCore/Modules/airplay/WebMediaSessionManager.cpp
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
    M Source/WebCore/css/StyleColor.cpp
    M Source/WebCore/css/StyleColor.h
    M Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.cpp
    M Source/WebCore/page/DragController.cpp
    M Source/WebCore/platform/network/ParsedContentType.h
    M Source/WebCore/rendering/RenderTreeAsText.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  Assorted style cleanups
https://bugs.webkit.org/show_bug.cgi?id=246046
<rdar://100785096>

Reviewed by Tim Nguyen.

Address a few style issues I noticed:
- Foo const& -> const Foo&
- Move some trivial constructors to the header when no additional includes are needed.
- Whitespace / brace placement issues

* Source/WebCore/Modules/airplay/WebMediaSessionManager.cpp:
(WebCore::ClientState::operator== const):
(WebCore::ClientState::operator ==  const): Deleted.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::performTextOperation):
(WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::Accessibility::isAccessibilityObjectSearchMatch):
(WebCore::Accessibility::isAccessibilityTextSearchMatch):
(WebCore::Accessibility::objectMatchesSearchCriteriaWithResultLimit):
(WebCore::Accessibility::findMatchingObjects):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::performTextOperation):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::deriveShadowRealmGlobalObject):
* Source/WebCore/css/StyleColor.cpp:
(WebCore::StyleColor::absoluteColor const):
(WebCore::StyleColor::currentColor): Deleted.
(WebCore::StyleColor::StyleColor): Deleted.
* Source/WebCore/css/StyleColor.h:
(WebCore::StyleColor::StyleColor):
(WebCore::StyleColor::currentColor):
* Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.cpp:
(WebCore::WebGLVertexArrayObjectBase::areAllEnabledAttribBuffersBound):
* Source/WebCore/page/DragController.cpp:
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret):
* Source/WebCore/platform/network/ParsedContentType.h:
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::currentColor): Deleted.
(WebCore::RenderStyle::isCurrentColor): Deleted.
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::currentColor):
(WebCore::RenderStyle::isCurrentColor):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInheritSize):
(WebCore::Style::BuilderCustom::applyInitialSize):
(WebCore::Style::BuilderCustom::applyInitialCounterIncrement):
(WebCore::Style::BuilderCustom::applyInitialCounterReset):
(WebCore::Style::BuilderCustom::applyInheritFill):

Canonical link: https://commits.webkit.org/255178@main




More information about the webkit-changes mailing list