[webkit-changes] [WebKit/WebKit] 40ee5a: [css-typed-om] css/css-typed-om/stylevalue-subclas...

Antoine Quint noreply at github.com
Wed Oct 5 06:20:00 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40ee5a40a17986c4f3d3fc4eaa852c6612473670
      https://github.com/WebKit/WebKit/commit/40ee5a40a17986c4f3d3fc4eaa852c6612473670
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-10-05 (Wed, 05 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkewY.tentative-expected.txt
    M Source/WebCore/css/typedom/transform/CSSSkewY.cpp
    M Source/WebCore/css/typedom/transform/CSSSkewY.h

  Log Message:
  -----------
  [css-typed-om] css/css-typed-om/stylevalue-subclasses/cssSkewY.tentative.html has failures
https://bugs.webkit.org/show_bug.cgi?id=246073

Reviewed by Antti Koivisto.

We need to check that the y member is an angle and raise an exception otherwise.
Additionally, it should be impossible to make a CSSSKewY a 3D operation so we override
setIs2D() to be a no-op.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssSkewY.tentative-expected.txt:
* Source/WebCore/css/typedom/transform/CSSSkewY.cpp:
(WebCore::CSSSkewY::setAy):
* Source/WebCore/css/typedom/transform/CSSSkewY.h:
(WebCore::CSSSkewY::setAy): Deleted.

Canonical link: https://commits.webkit.org/255168@main




More information about the webkit-changes mailing list