[webkit-changes] [WebKit/WebKit] 3e0b8a: [run-benchmark] Error when running a plan with sou...

Carlos Alberto Lopez Perez noreply at github.com
Wed Nov 30 20:48:39 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e0b8aa34ac72fb7a7334c6e4d4cd16099ccbb91
      https://github.com/WebKit/WebKit/commit/3e0b8aa34ac72fb7a7334c6e4d4cd16099ccbb91
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py
    M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py

  Log Message:
  -----------
  [run-benchmark] Error when running a plan with source type git_archive on a system with GNU tar
https://bugs.webkit.org/show_bug.cgi?id=248500

Reviewed by Dewei Zhu.

Create the git archive file in .tar.gz format so the format of
the archive file is the one expected by GNU tar when the flag
'z' is passed to it.

Meanwhile at this, add also the 'iteration' missing parameter in
the arguments of the skeleton BenchmarkRunner._run_one_test() class.
All the subclasses that inherit BenchmarkRunner() have this parameter
since 256544 at main

* Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder._prepare_content_from_local_git_archive):
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner._run_one_test):

Canonical link: https://commits.webkit.org/257218@main




More information about the webkit-changes mailing list